Fix exception case in compiler resolver #75000
Conversation
This fixes how we deal with exceptions in the compiler assembly resolver.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
| { | ||
| try | ||
| { | ||
| return _compilerAlc.LoadFromAssemblyName(assemblyName); |
There was a problem hiding this comment.
I'm wondering what was happening previously, where was the exception propagated (did it crash the whole process)?
There was a problem hiding this comment.
The code which consumes IAnalyzerAssemblyResolver guards against unexpected exceptions. Basically, that is an extension point and the compiler generally guards against unexpected exceptions coming from extensions. So this scenario was worknig overall but this specific component wasn't meeting its contract.
| @@ -415,7 +416,7 @@ internal string GetRealAnalyzerLoadPath(string originalFullPath) | |||
| return resolvedAssembly; | |||
| } | |||
| } | |||
| catch | |||
| catch (Exception ex) when (FatalError.ReportAndCatch(ex, ErrorSeverity.Diagnostic)) | |||
There was a problem hiding this comment.
@jjonescz your comment reminded me that we're essentially silently swallowing the exceptions from plugins. Changed that to be non-silent. It's not a fatal error but definitely something that should at least raise an alert if it happens. This would've caught the issue that I fixed with this PR.
This fixes how we deal with exceptions in the compiler assembly resolver.