Cache checksum computation at an collection-element level #75479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
approved these changes
Oct 11, 2024
| @@ -195,7 +195,16 @@ private static Checksum CreatePortableExecutableReferenceChecksum(PortableExecut | |||
| using (var writer = new ObjectWriter(stream, leaveOpen: true)) | |||
| { | |||
| WritePortableExecutableReferencePropertiesTo(reference, writer); | |||
| WriteMvidsTo(TryGetMetadata(reference), writer); | |||
| if (Path.IsPathRooted(reference.FilePath)) | |||
There was a problem hiding this comment.
We might want to run this through speedometer - it may flag new file access
There was a problem hiding this comment.
IsPathRooted is just a string operation, right?
There was a problem hiding this comment.
Is this waiting on a speedometer run?
3 tasks
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedometer traces showed some expenses here. What can happen is you might have a
List of referencesA that we compute a checksum against. But then if that list changes, but contains almost the entire set of references, we still recompute for the ones that are unchanged. This keeps around the checksums for the unchanged items.Also, we switch to consistently using a single mechanism to determine the mvid for PERef and ANalyzerReference. This avoids unnecessarily additional costs that exist to get teh full metadata info, that we don't need for checksum computation.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10440954&view=results