Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from ArrayBuilder => SharedPools for pooling inside AddBracePairsAsync #75630

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Change from ArrayBuilder => SharedPools for pooling inside AddBracePairsAsync #75630

merged 1 commit into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. Change from ArrayBuilder => SharedPools for pooling inside AddBracePa… 

    …irsAsync

It's pretty common for this array to exceed the size threshold supported by ArrayBuilder (128). For the files I'm testing on, the size supported by SharedPools (512) works much better.

Noticed this due to allocations in the editor's scrolling speedometer test, where it was showing up as 1.5% of allocations during scrolling.
    @ToddGrun
    ToddGrun committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    45c6be4 View commit details
    Browse the repository at this point in the history