Include project diagnostic suppressors in host analyzer execution #75684
+310
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
sharwell
commented
Nov 1, 2024
...tures/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.InProcOrRemoteHostAnalyzerRunner.cs
Outdated
Show resolved
Hide resolved
| @@ -146,6 +146,8 @@ static string GetLanguageSpecificId(string? language, string noLanguageId, strin | |||
| // Create driver that holds onto compilation and associated analyzers | |||
| var filteredProjectAnalyzers = projectAnalyzers.WhereAsArray(static a => !a.IsWorkspaceDiagnosticAnalyzer()); | |||
| var filteredHostAnalyzers = hostAnalyzers.WhereAsArray(static a => !a.IsWorkspaceDiagnosticAnalyzer()); | |||
| var filteredProjectSuppressors = filteredProjectAnalyzers.WhereAsArray(static a => a is DiagnosticSuppressor); | |||
| filteredHostAnalyzers = filteredHostAnalyzers.AddRange(filteredProjectSuppressors); | |||
There was a problem hiding this comment.
📝 This path is hit by the test that was failing, and revealed a case of AddRange causing a problem. It's not clear how well this or other paths are exercised, so I'm certainly concerned with bugs slipping through.
tmat
reviewed
Nov 21, 2024
| if (hostAnalyzerIds.Any()) | ||
| { | ||
| // If any host analyzers are active, make sure to also include any project diagnostic suppressors | ||
| hostBuilder.AddRange(projectAnalyzers.WhereAsArray(static a => a is DiagnosticSuppressor)); |
There was a problem hiding this comment.
Nit: Don't need "WhereAsArray" here, "Where" should do.
sharwell
commented
Nov 21, 2024
src/Workspaces/Remote/ServiceHub/Services/DiagnosticAnalyzer/DiagnosticComputer.cs
Outdated
Show resolved
Hide resolved
| Debug.Assert(diagnostics.Length == CompilationWithAnalyzers.GetEffectiveDiagnostics(diagnostics, compilation).Count()); | ||
|
|
||
| // ⚠️ No obvious way to keep this assertion | ||
| //Debug.Assert(diagnostics.Length == CompilationWithAnalyzers.GetEffectiveDiagnostics(diagnostics, compilation).Count()); |
There was a problem hiding this comment.
📝 Need to understand how important this assertion is. If it is not important, there are multiple parameters that can be removed to simplify this code.
There was a problem hiding this comment.
➡️ I removed this assertion and the parameters supporting it.
arunchndr
approved these changes
Nov 21, 2024
3 tasks
arunchndr
approved these changes
Nov 22, 2024
tmat
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75399