Keep comments when removing unnecessary lambda expressions #76015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Is 71300 the right issue? Seems already closed and not related |
dibarbet
approved these changes
Nov 22, 2024
| if (lastIndex < triviaList.Count && triviaList[lastIndex].IsEndOfLine()) | ||
| lastIndex++; | ||
|
|
||
| return triviaList.Take(lastIndex); |
There was a problem hiding this comment.
didn't quite get why we need this filtering at a glance - mind adding a comment on it?
There was a problem hiding this comment.
seems like its trying to get all the trivia up to the last comment and new line - but not sure why we aren't taking all the trivia?
There was a problem hiding this comment.
the idea is that we want to grab up through the last comment and the newline that follows and only move those over if it exists. we don't want to generally move things like when the user only has blank lines above the inner call. i will doc :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71300