Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run Code Cleanup on documents from the VS workspace #76019

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Only run Code Cleanup on documents from the VS workspace #76019

merged 2 commits into from
Nov 22, 2024
+23 −38

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #60867

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2024 01:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2024
jasonmalinowski
jasonmalinowski approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable (and simple enough). I was trying to think whether we should be instead doing something like getting the IDocumentSupportsFeatureService and checking one of the methods on that...but I can't really articulate a scenario where we'd need that.

@CyrusNajmabadi CyrusNajmabadi merged commit f6f08b4 into dotnet:main Nov 22, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 22, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the cleanupVSWorkspace branch November 22, 2024 21:32
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 23, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 25, 2024
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.

Code CleanUp - Remove unnecessary Using - removes usings from files not in loaded projects/solution
3 participants
@CyrusNajmabadi @jasonmalinowski @jjonescz