Fix location where inheritdoc doc comment is placed #76024
Merged
+98
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Nov 22, 2024
| { | ||
| return; | ||
| } | ||
| var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
it's a c# fixer. it always has a root.
CyrusNajmabadi
commented
Nov 22, 2024
|
|
||
| SemanticModel? semanticModel = null; | ||
| var semanticModel = await context.Document.GetRequiredSemanticModelAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
semantic models cost nothing in fixers. no point deferring.
CyrusNajmabadi
commented
Nov 22, 2024
| SourceText? sourceText = null; | ||
| var options = await document.GetLineFormattingOptionsAsync(cancellationToken).ConfigureAwait(false); | ||
| var newLine = options.NewLine; | ||
| var sourceText = await document.GetValueTextAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
we only got here because we want to fix things. deferring any of this stuff is pointless. the compiler already said there was a problem.
CyrusNajmabadi
commented
Nov 22, 2024
| // Comment | ||
| /// <inheritdoc/> |
There was a problem hiding this comment.
the new form is as better than the old form.
CyrusNajmabadi
commented
Nov 22, 2024
| // Comment 1 | ||
| /* Comment 2 */ public /* Comment 3 */ override void M /* Comment 4 */ () /* Comment 5 */ { } /* Comment 6 */ | ||
| /* Comment 2 */ /// <inheritdoc/> | ||
| public /* Comment 3 */ override void M /* Comment 4 */ () /* Comment 5 */ { } /* Comment 6 */ |
There was a problem hiding this comment.
this test case is pointless. no one writes cod ethis way. keeping things the same as they were before is not a desire here.
dibarbet
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61562