Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'scoped' modifier in metadata-as-source #76032

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #64906

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2024 05:44
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2024
@CyrusNajmabadi
Copy link
Member Author

@akhera99 ptal

case RefKind.RefReadOnly when forFunctionPointerReturnParameter:
result.Add(RefKeyword);
result.Add(ReadOnlyKeyword);
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this fallthrough to the case below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mebbe. my aring is little :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetadataAsSource should show scoped modifiers
3 participants