Remove support for inferring the return type of a local function. #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
4 - In Review
| // Specifically, the Interlocked.CompareExchange above succeeds, and will be seen by | ||
| // other threads, before the diagnostics have been recorded in this symbol, below. | ||
| // We can resolve this with a lock around this method and any other methods that | ||
| // manipulate _diagnostics, directly or indirectly. | ||
| AddDiagnostics(diagnostics.ToReadOnlyAndFree()); |
|
LGTM |
|
@dotnet-bot retest prtest/win/dbg/unit32 please |
|
The TODO should include a link to the bug. Otherwise LGTM |
|
I'm not sure about links from the compiler code to github. That would be a new precedent. On the other hand, it would make it easier to know which TODOs have already been made into issues. We're not likely to edit existing TODOs as we file issues for them, so I'd prefer to keep it this way. |
gafter
added a commit
that referenced
this pull request
Jan 14, 2016
Remove support for inferring the return type of a local function.
agocke
added a commit
to agocke/roslyn
that referenced
this pull request
Jun 14, 2016
Support for using `var` in a local function return type was already removed in PR dotnet#7916. This PR adds a test to verify that. Closes dotnet#10392.
agocke
added a commit
to agocke/roslyn
that referenced
this pull request
Jun 15, 2016
Support for using `var` in a local function return type was already removed in PR dotnet#7916. This PR adds a test to verify that. Closes dotnet#10392.
agocke
added a commit
that referenced
this pull request
Jun 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7832
@dotnet/roslyn-compiler Please review.