BuildAndTest.proj: quote tools path argument for RunTests.exe #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running tests when a user's home directory (by way of $(NuGetPackageRoot), by way of $(UserProfile)) has a space in it.
natidea
added
the
Community
|
@dotnet-bot test eta please |
|
@abock Please resolve merge conflicts to allow the build to proceed. Thanks. |
|
@natidea I will get back to this next week. I have already rebased this once for a merge conflict. Hopefully this won't keep happening! |
|
Never saw an update on this, so I grabbed your change, and merged with the latest here: #9333. I just resubmitted with you as the author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows running tests when a user's home directory (by way of
$(NuGetPackageRoot), by way of$(UserProfile)) has a space in it.