Do not allow a let-statement as an embedded statement. #9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not allow a local function declaration as an embedded statement. Handle deep expressions better in the pattern variable finder.
gafter
added
Area-Compilers
New Language Feature - Pattern Matching
|
This should fix a few test failures due to the pattern variable finder overflowing the stack. |
gafter
added a commit
that referenced
this pull request
Feb 26, 2016
Do not allow a let-statement as an embedded statement.
| s_poolInstance.Free(finder); | ||
| return result; | ||
| } | ||
|
|
||
| private void VisitExpressions() | ||
| { | ||
| while (expressionsToVisit.Count != 0) |
There was a problem hiding this comment.
This is doesn't preserve the order in which expressions are visited, which leads to a wrong behavior when duplicate declarations are involved. Please fix.
There was a problem hiding this comment.
See how it was done for declaration expressions in LocalScopeBinder.cs.
The implementation of VisitBinaryExpression of interest was removed in 9d36a64a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow a local function declaration as an embedded statement.
Handle deep expressions better in the pattern variable finder.
@AlekseyTs @CyrusNajmabadi @jaredpar FYI