Test/fix scoping of pattern variables in expression-bodied functions and properties. #9265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and properties. Fixes dotnet#8810. Related to dotnet#8816.
| @@ -215,11 +221,16 @@ private Binder GetEnclosingBinder(CSharpSyntaxNode node, int position) | |||
| binder = RootBinder.GetBinder(current); | |||
| } | |||
| } | |||
| else if (current.Kind() == SyntaxKind.ArrowExpressionClause && current.Parent?.Kind() == SyntaxKind.LocalFunctionStatement) | |||
There was a problem hiding this comment.
Nit: It looks like this block and the one above it could be combined.
There was a problem hiding this comment.
I don't think it will make code easier to understand. In fact, I believe it will make it much harder to understand.
|
👍 |
|
Test prtest/mac/dbg/unit32 please. |
AlekseyTs
added a commit
that referenced
this pull request
Feb 28, 2016
Test/fix scoping of pattern variables in expression-bodied functions and properties.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8810.
Related to #8816.
@gafter, @jaredpar, @dotnet/roslyn-compiler Please review.