Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rename works for property pattern members #9440

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

gafter
Copy link
Member

@gafter gafter commented Mar 3, 2016

Closes #9079 #9080

@gafter gafter added Area-IDE Test Test failures in roslyn-CI New Language Feature - Pattern Matching Pattern Matching labels Mar 3, 2016
@gafter gafter self-assigned this Mar 3, 2016
@gafter gafter added this to the 2.0 (RC) milestone Mar 3, 2016
@gafter
Copy link
Member Author

gafter commented Mar 3, 2016

@dotnet/roslyn-ide @CyrusNajmabadi Please review.

@CyrusNajmabadi
Copy link
Member

I'd also like specific tests that renaming the type itself happens to rename the usage of the type in the pattern.

@CyrusNajmabadi
Copy link
Member

👍 Once that test is added.

@gafter
Copy link
Member Author

gafter commented Mar 3, 2016

@CyrusNajmabadi How about now?

@CyrusNajmabadi
Copy link
Member

👍

1 similar comment
@DustinCampbell
Copy link
Member

👍

@gafter gafter modified the milestones: 2.0 (RC), 2.0 (Preview) Mar 3, 2016
gafter added a commit that referenced this pull request Mar 3, 2016
Ensure rename works for property pattern members
@gafter gafter merged commit 1b54ac1 into dotnet:features/patterns Mar 3, 2016
@gafter gafter deleted the patterns-9079 branch May 24, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants