-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RCS1187 #1150
Merged
Merged
Fix RCS1187 #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesHargreaves12
force-pushed
the
fix/RCS1187
branch
from
August 6, 2023 14:37
6987ed8
to
afe0345
Compare
josefpihrt
requested changes
Aug 7, 2023
src/Common/CSharp/Analysis/UseConstantInsteadOfFieldAnalysis.cs
Outdated
Show resolved
Hide resolved
josefpihrt
requested changes
Aug 10, 2023
josefpihrt
requested changes
Aug 11, 2023
src/Common/CSharp/Analysis/UseConstantInsteadOfFieldAnalysis.cs
Outdated
Show resolved
Hide resolved
josefpihrt
approved these changes
Aug 12, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing a static field to a constant changes the meaning of that symbol in the decorators. For example, applying RCS1187 in the following example will lead to a compile-time error (CS0110):