Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing framework #1214

Merged
merged 18 commits into from
Oct 18, 2023
Merged

Improve testing framework #1214

merged 18 commits into from
Oct 18, 2023

Conversation

josefpihrt
Copy link
Collaborator

No description provided.

@josefpihrt josefpihrt self-assigned this Oct 1, 2023
@AlmarAubel
Copy link

ohh yes this is great. I was building my own analyzer Roslynator.Testing.CSharp and tried to use a copy of AbstractCSharpDiagnosticVerifier but it was using a lot of internal functions it looks like I can now just use CompilerDiagnosticFixVerifier

@josefpihrt
Copy link
Collaborator Author

@AlmarAubel @nathanpovo If you have any comments please add it to this PR. Otherwise, the PR is ready to be merged.

@nathanpovo
Copy link

Thanks for your hard work @josefpihrt!

Managed to get some time to test this out. Had to add a reference to a local version of the Testing.Common and Testing.CSharp.Xunit project (it would not work with just a reference to the Testing.CSharp.Xunit project).

Didn't have the chance to do a proper test suite using the new package but it looks to be ok from the couple of tests I tried.

@josefpihrt josefpihrt merged commit 7eb8e16 into main Oct 18, 2023
14 checks passed
@josefpihrt josefpihrt deleted the feature/testing-framework branch October 18, 2023 15:06
@AlmarAubel
Copy link

Thank you after creating a copy of AbstractCSharpDiagnosticVerifier I could use it on my own analyzers.

Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants