Skip to content

Commit

Permalink
use PlatformSpecific attribute to supress platform specific Quic tests (
Browse files Browse the repository at this point in the history
#82933)

* use PlatformSpecific attribute to supress platform specific Quic tests

* Update src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
  • Loading branch information
wfurt and stephentoub authored Mar 3, 2023
1 parent f604caf commit 3853cb8
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,17 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException()

[ActiveIssue("https://github.com/dotnet/runtime/issues/73290", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82885", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.SupportsTls13))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.SupportsTls13))]
[PlatformSpecific(TestPlatforms.Windows)]
public void SupportedWindowsPlatforms_IsSupportedIsTrue()
{
Assert.True(QuicListener.IsSupported);
Assert.True(QuicConnection.IsSupported);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/81901", typeof(PlatformDetection), nameof(PlatformDetection.IsAlpine314), nameof(PlatformDetection.IsInContainer))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux))]
[Fact]
[PlatformSpecific(TestPlatforms.Linux)]
public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
{
using Process find = new Process();
Expand Down Expand Up @@ -61,7 +63,8 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsRaspbian10), nameof(PlatformDetection.IsArmv6Process), nameof(PlatformDetection.IsInContainer))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsPpc64leProcess))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux), nameof(PlatformDetection.IsInHelix))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInHelix))]
[PlatformSpecific(TestPlatforms.Linux)]
public void SupportedLinuxPlatforms_IsSupportedIsTrue()
{
_output.WriteLine($"Running on {PlatformDetection.GetDistroVersionString()}");
Expand Down

0 comments on commit 3853cb8

Please sign in to comment.