-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
JIT ARM32: Fix wrong emitAttr passed for loads/stores in PUTARG_STK (#…
…68540) On arm architectures the small load/store instructions all work larger registers and for loads the instruction automatically normalizes the result. Due to this we always expect to pass the normalized size for loads/stores when generating these instructions, but in this particular place we did not do so, resulting in asserts on arm32. On arm64 the function ignores the size so nothing happens. Fix #60827
- Loading branch information
1 parent
4ed596e
commit 561957b
Showing
3 changed files
with
43 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/tests/JIT/Regression/JitBlue/Runtime_60827/Runtime_60827.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Runtime.CompilerServices; | ||
|
||
public struct S0 | ||
{ | ||
public ushort F1; | ||
public ushort F2; | ||
public byte F3; | ||
|
||
public void M21() | ||
{ | ||
M25(0, 1, 2, 3, this); | ||
} | ||
|
||
[MethodImpl(MethodImplOptions.NoInlining)] | ||
static void M25(int r0, int r1, int r2, int r3, S0 stkArg) | ||
{ | ||
} | ||
} | ||
|
||
public class Runtime_60827 | ||
{ | ||
public static int Main() | ||
{ | ||
new S0().M21(); | ||
|
||
return 100; | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
src/tests/JIT/Regression/JitBlue/Runtime_60827/Runtime_60827.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<OutputType>Exe</OutputType> | ||
<DebugType>None</DebugType> | ||
<Optimize>True</Optimize> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="$(MSBuildProjectName).cs" /> | ||
</ItemGroup> | ||
</Project> |