Avoid char[] allocation in AltSvcHeaderParser (#103764)

dotnet · Jun 21, 2024 · 6bf2bc8 · 6bf2bc8
1 parent 3a8992a
commit 6bf2bc8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/Headers/AltSvcHeaderParser.cs b/src/libraries/System.Net.Http/src/System/Net/Http/Headers/AltSvcHeaderParser.cs
@@ -265,7 +265,9 @@ private static bool TryReadUnknownPercentEncodedAlpnProtocolName(ReadOnlySpan<ch
                 return true;
             }
 
-            var builder = new ValueStringBuilder(value.Length <= 128 ? stackalloc char[128] : new char[value.Length]);
+            var builder = value.Length <= 128 ?
+                new ValueStringBuilder(stackalloc char[128]) :
+                new ValueStringBuilder(value.Length);
 
             do
             {
@@ -276,6 +278,7 @@ private static bool TryReadUnknownPercentEncodedAlpnProtocolName(ReadOnlySpan<ch
 
                 if ((value.Length - idx) < 3 || !TryReadAlpnHexDigit(value[1], out int hi) || !TryReadAlpnHexDigit(value[2], out int lo))
                 {
+                    builder.Dispose();
                     result = null;
                     return false;
                 }