Skip to content

Commit

Permalink
[wasm][aot] Enable System.Runtime.Tests (#54960)
Browse files Browse the repository at this point in the history
.. this hasn't crashed in last 14 days on the tracking PR.
- And disable the one failing test with ActiveIssue
  • Loading branch information
radical authored Jul 1, 2021
1 parent e97d67e commit 779b794
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,7 @@ public void GetTypeByName_Invalid(string typeName, Type expectedException, bool
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52393", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
public void GetTypeByName_InvokeViaReflection_Success()
{
MethodInfo method = typeof(Type).GetMethod("GetType", new[] { typeof(string) });
Expand Down
3 changes: 0 additions & 3 deletions src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,6 @@
<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true' and '$(RunAOTCompilation)' == 'true'">
<!-- Issue: https://github.com/dotnet/runtime/issues/54194 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj" />

<!-- Issue: https://github.com/dotnet/runtime/issues/52393 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime/tests/System.Runtime.Tests.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true'">
Expand Down

0 comments on commit 779b794

Please sign in to comment.