address feedback

dotnet · Feb 14, 2020 · 887f164 · 887f164
1 parent 25ecf23
commit 887f164
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.../System.Security.Cryptography.Cng/src/Internal/Cryptography/BasicSymmetricCipherNCrypt.cs b/.../System.Security.Cryptography.Cng/src/Internal/Cryptography/BasicSymmetricCipherNCrypt.cs
@@ -104,7 +104,7 @@ protected sealed override void Dispose(bool disposing)
                 if (_cngKey != null)
                 {
                     _cngKey.Dispose();
-                    _cngKey = null;
+                    _cngKey = null!;
                 }
             }
 
@@ -120,7 +120,7 @@ private void Reset()
             }
         }
 
-        private CngKey? _cngKey;
+        private CngKey _cngKey;
         private readonly bool _encrypting;
 
         private static readonly CngProperty s_ECBMode =

diff --git a/...raries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKey.Export.cs b/...raries/System.Security.Cryptography.Cng/src/System/Security/Cryptography/CngKey.Export.cs
@@ -100,7 +100,7 @@ internal byte[] ExportPkcs8KeyBlob(
                 out byte[]? allocated);
 
             Debug.Assert(ret);
-            Debug.Assert(allocated != null); // on account of allocate parameter being true
+            Debug.Assert(allocated != null); // since `allocate: true`
             return allocated;
         }
 

diff --git a/...stem.Security.Cryptography.Cng/src/System/Security/Cryptography/ECDiffieHellmanCng.Key.cs b/...stem.Security.Cryptography.Cng/src/System/Security/Cryptography/ECDiffieHellmanCng.Key.cs
@@ -99,7 +99,7 @@ public override void GenerateKey(ECCurve curve)
 
         private CngKey GetKey()
         {
-            CngKey? key = null;
+            CngKey key;
 
             if (_core.IsKeyGeneratedNamedCurve())
             {
@@ -108,7 +108,7 @@ private CngKey GetKey()
             }
             else
             {
-                CngAlgorithm? algorithm = null;
+                CngAlgorithm algorithm;
                 int keySize = 0;
 
                 // Map the current key size to a CNG algorithm name