NativeAOT the XUnitLogChecker (#103795)

This breaks the dependency on having dotnet installed when running tests.
dotnet · Sep 4, 2024 · 9546425 · 9546425
1 parent 68c4551
commit 9546425
Show file tree

Hide file tree

Showing 10 changed files with 73 additions and 60 deletions.
diff --git a/eng/testing/RunnerTemplate.cmd b/eng/testing/RunnerTemplate.cmd
@@ -109,15 +109,12 @@ if NOT "%__IsXUnitLogCheckerSupported%"=="1" (
 echo ----- start ===============  XUnitLogChecker Output =====================================================
 
 set DOTNET_EXE=%RUNTIME_PATH%\dotnet.exe
-set XUNITLOGCHECKER_DLL=%HELIX_CORRELATION_PAYLOAD%\XUnitLogChecker.dll
-set XUNITLOGCHECKER_COMMAND=%DOTNET_EXE% --roll-forward Major %XUNITLOGCHECKER_DLL% --dumps-path %HELIX_DUMP_FOLDER%
+set XUNITLOGCHECKER_EXE=%HELIX_CORRELATION_PAYLOAD%\XUnitLogChecker.exe
+set XUNITLOGCHECKER_COMMAND=%XUNITLOGCHECKER_EXE% --dumps-path %HELIX_DUMP_FOLDER%
 set XUNITLOGCHECKER_EXIT_CODE=1
 
-if NOT EXIST %DOTNET_EXE% (
-  echo dotnet.exe does not exist in the expected location: %DOTNET_EXE%
-  GOTO XUNITLOGCHECKER_END
-) else if NOT EXIST %XUNITLOGCHECKER_DLL% (
-  echo XUnitLogChecker.dll does not exist in the expected location: %XUNITLOGCHECKER_DLL%
+if NOT EXIST %XUNITLOGCHECKER_EXE% (
+  echo XUnitLogChecker does not exist in the expected location: %XUNITLOGCHECKER_EXE%
   GOTO XUNITLOGCHECKER_END
 )
 

diff --git a/eng/testing/RunnerTemplate.sh b/eng/testing/RunnerTemplate.sh
@@ -79,23 +79,19 @@ function invoke_xunitlogchecker {
   local dump_folder=$1
 
   total_dumps=$(find $dump_folder -name "*.dmp" | wc -l)
-  
+
   if [[ $total_dumps > 0 ]]; then
     echo "Total dumps found in $dump_folder: $total_dumps"
-    xunitlogchecker_file_name="$HELIX_CORRELATION_PAYLOAD/XUnitLogChecker.dll"
-    dotnet_file_name="$RUNTIME_PATH/dotnet"
-
-    if [[ ! -f $dotnet_file_name ]]; then
-      echo "'$dotnet_file_name' was not found. Unable to run XUnitLogChecker."
-      xunitlogchecker_exit_code=1
-    elif [[ ! -f $xunitlogchecker_file_name ]]; then 
-      echo "'$xunitlogchecker_file_name' was not found. Unable to print dump file contents."
+    xunitlogchecker_file_name="$HELIX_CORRELATION_PAYLOAD/XUnitLogChecker"
+
+    if [[ ! -f $xunitlogchecker_file_name ]]; then
+      echo "XUnitLogChecker does not exist in the expected location: $xunitlogchecker_file_name"
       xunitlogchecker_exit_code=2
     elif [[ ! -d $dump_folder ]]; then
       echo "The dump directory '$dump_folder' does not exist."
     else
       echo "Executing XUnitLogChecker in $dump_folder..."
-      cmd="$dotnet_file_name --roll-forward Major $xunitlogchecker_file_name --dumps-path $dump_folder"
+      cmd="$xunitlogchecker_file_name --dumps-path $dump_folder"
       echo "$cmd"
       $cmd
       xunitlogchecker_exit_code=$?
@@ -207,7 +203,7 @@ if [[ $system_name == "Linux" && $test_exitcode -ne 0 ]]; then
   if [[ -e /proc/sys/kernel/core_uses_pid && "1" == $(cat /proc/sys/kernel/core_uses_pid) ]]; then
     core_name_uses_pid=1
   fi
-  
+
   # The osx dumps are too large to egress the machine
   echo Looking around for any Linux dumps...
 
@@ -240,8 +236,9 @@ elif [[ -z "$__IsXUnitLogCheckerSupported" ]]; then
 elif [[ "$__IsXUnitLogCheckerSupported" != "1" ]]; then
   echo "XUnitLogChecker not supported for this test case. Skipping."
 else
+  echo "XUnitLogChecker status: $__IsXUnitLogCheckerSupported"
   echo ----- start ===============  XUnitLogChecker Output =====================================================
-  
+
   invoke_xunitlogchecker "$HELIX_DUMP_FOLDER"
 
   if [[ $xunitlogchecker_exit_code -ne 0 ]]; then

diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj
@@ -433,7 +433,7 @@
     <ProjectExclusions Remove="$(MSBuildThisFileDirectory)System.Collections\tests\System.Collections.Tests.csproj" />
     <ProjectExclusions Remove="$(MSBuildThisFileDirectory)System.IO.IsolatedStorage\tests\System.IO.IsolatedStorage.Tests.csproj" />
   </ItemGroup>
-  
+
   <ItemGroup Condition="'$(TestNativeAot)' == 'true' or '$(TargetsMobile)' == 'true'">
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.Extensions\tests\BinaryFormatTests\System.Resources.Extensions.BinaryFormat.Tests.csproj" />
     <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.Extensions\tests\CompatTests\System.Resources.Extensions.Compat.Tests.csproj" />
@@ -767,7 +767,8 @@
   <ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and '$(IsXUnitLogCheckerSupported)' == 'true'">
     <ProjectReference
       Include="$(RepoRoot)src\tests\Common\XUnitLogChecker\XUnitLogChecker.csproj"
-      AdditionalProperties="%(AdditionalProperties);Configuration=Release;OutDir=$(XUnitLogCheckerLibrariesOutDir)" />
+      Targets="Publish"
+      AdditionalProperties="%(AdditionalProperties);_IsPublishing=true;Configuration=Release;PublishDir=$(XUnitLogCheckerLibrariesOutDir);ROOTFS_DIR=$(ROOTFS_DIR);RuntimeIdentifier=$(OutputRID)" />
   </ItemGroup>
 
   <Target Name="GenerateMergedCoverageReport"

diff --git a/src/tests/Common/Coreclr.TestWrapper/Coreclr.TestWrapper.csproj b/src/tests/Common/Coreclr.TestWrapper/Coreclr.TestWrapper.csproj
@@ -4,7 +4,10 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <NuGetTargetMoniker>$(NetCoreAppCurrentToolTargetFrameworkMoniker)</NuGetTargetMoniker>
     <NuGetTargetMonikerShort>$(NetCoreAppToolCurrent)</NuGetTargetMonikerShort>
-    <RunAnalyzers>false</RunAnalyzers>
+    <Nullable>enable</Nullable>
+    <RunAnalyzers>true</RunAnalyzers>
+    <EnableAotAnalyzer>true</EnableAotAnalyzer>
+    <EnableTrimAnalyzer>true</EnableTrimAnalyzer>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs b/src/tests/Common/Coreclr.TestWrapper/CoreclrTestWrapperLib.cs
@@ -1,7 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 //
-#nullable disable
 
 using System;
 using System.Collections.Generic;
@@ -100,7 +99,7 @@ public unsafe struct ProcessEntry32W
     static class @libproc
     {
         [DllImport(nameof(libproc))]
-        private static extern int proc_listchildpids(int ppid, int[] buffer, int byteSize);
+        private static extern int proc_listchildpids(int ppid, int[]? buffer, int byteSize);
 
         public static unsafe bool ListChildPids(int ppid, out int[] buffer)
         {
@@ -171,7 +170,7 @@ private unsafe static IEnumerable<Process> Windows_GetChildren(Process process)
         private static IEnumerable<Process> Linux_GetChildren(Process process)
         {
             var children = new List<Process>();
-            List<int> childPids = null;
+            List<int>? childPids = null;
 
             try
             {
@@ -188,7 +187,7 @@ private static IEnumerable<Process> Linux_GetChildren(Process process)
                 pgrepInfo.RedirectStandardOutput = true;
                 pgrepInfo.Arguments = $"-P {process.Id}";
 
-                using Process pgrep = Process.Start(pgrepInfo);
+                using Process pgrep = Process.Start(pgrepInfo)!;
 
                 string[] pidStrings = pgrep.StandardOutput.ReadToEnd().Split('\n', StringSplitOptions.RemoveEmptyEntries);
                 pgrep.WaitForExit();
@@ -271,7 +270,11 @@ static bool CollectCrashDumpWithMiniDumpWriteDump(Process process, string crashD
 
         static bool CollectCrashDumpWithCreateDump(Process process, string crashDumpPath, StreamWriter outputWriter)
         {
-            string coreRoot = Environment.GetEnvironmentVariable("CORE_ROOT");
+            string? coreRoot = Environment.GetEnvironmentVariable("CORE_ROOT");
+            if (coreRoot is null)
+            {
+                throw new InvalidOperationException("CORE_ROOT environment variable is not set.");
+            }
             string createdumpPath = Path.Combine(coreRoot, "createdump");
             string arguments = $"--crashreport --name \"{crashDumpPath}\" {process.Id} --withheap";
             Process createdump = new Process();
@@ -388,7 +391,7 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
                 }
 
                 Console.WriteLine("=========================================");
-                string userName = Environment.GetEnvironmentVariable("USER");
+                string? userName = Environment.GetEnvironmentVariable("USER");
                 if (!string.IsNullOrEmpty(userName))
                 {
                     if (!RunProcess("sudo", $"chown {userName} {crashReportJsonFile}", Console.Out))
@@ -426,8 +429,8 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
                 Console.WriteLine($"Error reading {crashReportJsonFile}: {ex.ToString()}");
                 return false;
             }
-            dynamic crashReport = JsonSerializer.Deserialize<JsonObject>(contents);
-            var threads = crashReport["payload"]["threads"];
+            var crashReport = JsonNode.Parse(contents)!;
+            var threads = (JsonArray)crashReport["payload"]!["threads"]!;
 
             // The logic happens in 3 steps:
             // 1. Read the crashReport.json file, locate all the addresses of interest and then build
@@ -443,7 +446,7 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
             foreach (var thread in threads)
             {
 
-                if (thread["native_thread_id"] == null)
+                if (thread!["native_thread_id"] == null)
                 {
                     continue;
                 }
@@ -452,21 +455,21 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
                 addrBuilder.AppendLine("----------------------------------");
                 addrBuilder.AppendLine($"Thread Id: {thread["native_thread_id"]}");
                 addrBuilder.AppendLine("      Child SP               IP Call Site");
-                var stack_frames = thread["stack_frames"];
+                var stack_frames = (JsonArray)thread["stack_frames"]!;
                 foreach (var frame in stack_frames)
                 {
-                    addrBuilder.Append($"{SKIP_LINE_TAG} {frame["stack_pointer"]} {frame["native_address"]} ");
-                    bool isNative = (string)frame["is_managed"] == "false";
+                    addrBuilder.Append($"{SKIP_LINE_TAG} {frame!["stack_pointer"]} {frame["native_address"]} ");
+                    bool isNative = (string)frame["is_managed"]! == "false";
 
                     if (isNative)
                     {
-                        string nativeModuleName = (string)frame["native_module"];
-                        string unmanagedName = (string)frame["unmanaged_name"];
+                        var nativeModuleName = (string)frame["native_module"]!;
+                        var unmanagedName = (string)frame["unmanaged_name"]!;
 
                         if ((nativeModuleName != null) && (knownNativeModules.Contains(nativeModuleName)))
                         {
                             // Need to use llvm-symbolizer (only if module_address != 0)
-                            AppendAddress(addrBuilder, coreRoot, nativeModuleName, (string)frame["native_address"], (string)frame["module_address"]);
+                            AppendAddress(addrBuilder, coreRoot, nativeModuleName, (string)frame["native_address"]!, (string)frame["module_address"]!);
                         }
                         else if ((nativeModuleName != null) || (unmanagedName != null))
                         {
@@ -482,8 +485,8 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
                     }
                     else
                     {
-                        string fileName = (string)frame["filename"];
-                        string methodName = (string)frame["method_name"];
+                        var fileName = (string)frame["filename"]!;
+                        var methodName = (string)frame["method_name"]!;
 
                         if ((fileName != null) || (methodName != null))
                         {
@@ -507,7 +510,7 @@ public static bool TryPrintStackTraceFromCrashReport(string crashReportJsonFile,
                 }
             }
 
-            string symbolizerOutput = null;
+            string? symbolizerOutput = null;
 
             Process llvmSymbolizer = new Process()
             {
@@ -602,7 +605,7 @@ private static void AppendAddress(StringBuilder sb, string coreRoot, string nati
 
         public static bool TryPrintStackTraceFromDmp(string dmpFile, TextWriter outputWriter)
         {
-            string targetArchitecture = Environment.GetEnvironmentVariable(TEST_TARGET_ARCHITECTURE_ENVIRONMENT_VAR);
+            string? targetArchitecture = Environment.GetEnvironmentVariable(TEST_TARGET_ARCHITECTURE_ENVIRONMENT_VAR);
             if (string.IsNullOrEmpty(targetArchitecture))
             {
                 outputWriter.WriteLine($"Environment variable {TEST_TARGET_ARCHITECTURE_ENVIRONMENT_VAR} is not set.");
@@ -675,10 +678,10 @@ public int RunTest(string executable, string outputFile, string errorFile, strin
 
             // If a timeout was given to us by an environment variable, use it instead of the default
             // timeout.
-            string environmentVar = Environment.GetEnvironmentVariable(TIMEOUT_ENVIRONMENT_VAR);
+            string? environmentVar = Environment.GetEnvironmentVariable(TIMEOUT_ENVIRONMENT_VAR);
             int timeout = environmentVar != null ? int.Parse(environmentVar) : DEFAULT_TIMEOUT_MS;
             bool collectCrashDumps = Environment.GetEnvironmentVariable(COLLECT_DUMPS_ENVIRONMENT_VAR) != null;
-            string crashDumpFolder = Environment.GetEnvironmentVariable(CRASH_DUMP_FOLDER_ENVIRONMENT_VAR);
+            string? crashDumpFolder = Environment.GetEnvironmentVariable(CRASH_DUMP_FOLDER_ENVIRONMENT_VAR);
 
             var outputStream = new FileStream(outputFile, FileMode.Create);
             var errorStream = new FileStream(errorFile, FileMode.Create);

diff --git a/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs b/src/tests/Common/Coreclr.TestWrapper/MobileAppHandler.cs
@@ -63,8 +63,8 @@ private static int HandleMobileApp(string action, string platform, string catego
                 if (platformValueFlag && actionValueFlag)
                 {
                     int timeout = 240000; // Set timeout to 4 mins, because the installation on Android arm64/32 devices could take up to 10 mins on CI
-                    string dotnetCmd_raw = System.Environment.GetEnvironmentVariable("__TestDotNetCmd");
-                    string xharnessCmd_raw = System.Environment.GetEnvironmentVariable("XHARNESS_CLI_PATH");
+                    string? dotnetCmd_raw = System.Environment.GetEnvironmentVariable("__TestDotNetCmd");
+                    string? xharnessCmd_raw = System.Environment.GetEnvironmentVariable("XHARNESS_CLI_PATH");
                     string dotnetCmd = string.IsNullOrEmpty(dotnetCmd_raw) ? "dotnet" : dotnetCmd_raw;
                     string xharnessCmd = string.IsNullOrEmpty(xharnessCmd_raw) ? "xharness" : $"exec {xharnessCmd_raw}";
                     string appExtension = platform == "android" ? "apk" : "app";
@@ -194,9 +194,9 @@ private static string ConvertCmd2Arg(string cmd)
 
         private static void CreateRetryFile(string fileName, int exitCode, string appName)
         {
-            using (StreamWriter writer = new StreamWriter(fileName))  
+            using (StreamWriter writer = new StreamWriter(fileName))
             {
-                writer.WriteLine($"appName: {appName}; exitCode: {exitCode}"); 
+                writer.WriteLine($"appName: {appName}; exitCode: {exitCode}");
             }
         }
 

diff --git a/src/tests/Common/XUnitLogChecker/XUnitLogChecker.cs b/src/tests/Common/XUnitLogChecker/XUnitLogChecker.cs
@@ -56,7 +56,7 @@ private enum TagCategory { OPENING, CLOSING }
 
     private static LogCheckerConfigParameters s_configuration;
 
-    static int Main(string[] args)
+    public static int Main(string[] args)
     {
         s_configuration = new LogCheckerConfigParameters();
 

diff --git a/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj b/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj
@@ -5,15 +5,20 @@
     <TargetFramework>$(NetCoreAppToolCurrent)</TargetFramework>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <PublishAot>true</PublishAot>
+    <SuppressTrimAnalysisWarnings>false</SuppressTrimAnalysisWarnings>
+    <LinkerFlavor Condition="'$(CrossBuild)' == 'true' and '$(TargetsLinux)' == 'true'">lld</LinkerFlavor>
+    <SysRoot Condition="'$(CrossBuild)' == 'true' and '$(HostOS)' != 'windows'">$(ROOTFS_DIR)</SysRoot>
   </PropertyGroup>
 
   <ItemGroup>
-    <Compile Include="XUnitLogChecker.cs" />
+    <CustomLinkerArg Condition="'$(CrossBuild)' == 'true' and '$(_hostArchitecture)' == '$(_targetArchitecture)' and '$(_hostOS)' != 'windows'" Include="--gcc-toolchain=$(ROOTFS_DIR)/usr" />
+    <Compile Include="$(MSBuildThisFileDirectory)XUnitLogChecker.cs" />
   </ItemGroup>
 
   <ItemGroup>
-    <Compile Include="../Coreclr.TestWrapper/CoreclrTestWrapperLib.cs" Link="CoreclrTestWrapperLib.cs" />
-    <Compile Include="../Coreclr.TestWrapper/MobileAppHandler.cs" Link="MobileAppHandler.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)../Coreclr.TestWrapper/CoreclrTestWrapperLib.cs" Link="CoreclrTestWrapperLib.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)../Coreclr.TestWrapper/MobileAppHandler.cs" Link="MobileAppHandler.cs" />
   </ItemGroup>
 
 </Project>
diff --git a/src/tests/Common/helixpublishwitharcade.proj b/src/tests/Common/helixpublishwitharcade.proj
@@ -67,7 +67,7 @@
   <PropertyGroup>
     <CoreRootDirectory>$(TestBinDir)Tests\Core_Root\</CoreRootDirectory>
     <CoreRootDirectory>$([MSBuild]::NormalizeDirectory($(CoreRootDirectory)))</CoreRootDirectory>
-    <XUnitLogCheckerDirectory>$(TestBinDir)Common\XUnitLogChecker\</XUnitLogCheckerDirectory>
+    <XUnitLogCheckerDirectory>$(TestBinDir)XUnitLogChecker\</XUnitLogCheckerDirectory>
     <XUnitLogCheckerDirectory>$([MSBuild]::NormalizeDirectory($(XUnitLogCheckerDirectory)))</XUnitLogCheckerDirectory>
     <LegacyPayloadsRootDirectory>$(TestBinDir)LegacyPayloads\</LegacyPayloadsRootDirectory>
     <LegacyPayloadsRootDirectory>$([MSBuild]::NormalizeDirectory($(LegacyPayloadsRootDirectory)))</LegacyPayloadsRootDirectory>
@@ -392,7 +392,6 @@
     <PropertyGroup>
       <XUnitLogCheckerHelixPath Condition="'$(TestWrapperTargetsWindows)' != 'true'">%24HELIX_CORRELATION_PAYLOAD/</XUnitLogCheckerHelixPath>
       <XUnitLogCheckerHelixPath Condition="'$(TestWrapperTargetsWindows)' == 'true'">%25HELIX_CORRELATION_PAYLOAD%25/</XUnitLogCheckerHelixPath>
-      <XUnitLogCheckerHelixPath>$(XUnitLogCheckerHelixPath)XUnitLogChecker/</XUnitLogCheckerHelixPath>
 
       <XUnitLogCheckerArgs>--results-path $(_MergedWrapperRunScriptDirectoryRelative)</XUnitLogCheckerArgs>
       <XUnitLogCheckerArgs>$(XUnitLogCheckerArgs) --test-wrapper $(_MergedWrapperName)</XUnitLogCheckerArgs>
@@ -401,7 +400,7 @@
       <XUnitLogCheckerArgs Condition="'$(TestWrapperTargetsWindows)' != 'true'">$(XUnitLogCheckerArgs) %24HELIX_DUMP_FOLDER</XUnitLogCheckerArgs>
       <XUnitLogCheckerArgs Condition="'$(TestWrapperTargetsWindows)' == 'true'">$(XUnitLogCheckerArgs) %25HELIX_DUMP_FOLDER%25</XUnitLogCheckerArgs>
 
-      <XUnitLogCheckerCommand>dotnet $(XUnitLogCheckerHelixPath)XUnitLogChecker.dll $(XUnitLogCheckerArgs)</XUnitLogCheckerCommand>
+      <XUnitLogCheckerCommand>$(XUnitLogCheckerHelixPath)XUnitLogChecker$(ExeSuffix) $(XUnitLogCheckerArgs)</XUnitLogCheckerCommand>
     </PropertyGroup>
 
     <ItemGroup>
@@ -426,7 +425,7 @@
       <HelixCommandLines Condition="'$(TestWrapperTargetsWindows)' != 'true'" Include="test_exit_code=%24%3F" />
 
       <!-- Add the XUnitLogChecker's running command and store its exit code. -->
-      <HelixCommandLines Include="$(XUnitLogCheckerCommand)" />
+      <HelixCommandLines Condition="'$(IsXunitLogCheckerSupported)' == 'true'" Include="$(XUnitLogCheckerCommand)" />
       <HelixCommandLines Condition="'$(TestWrapperTargetsWindows)' == 'true'" Include="set xunitlogchecker_exit_code=%25ERRORLEVEL%25" />
       <HelixCommandLines Condition="'$(TestWrapperTargetsWindows)' != 'true'" Include="xunitlogchecker_exit_code=%24%3F" />
 
@@ -761,7 +760,7 @@
     <HelixCorrelationPayload Include="$(CoreRootDirectory)" />
 
     <!-- Browser-Wasm and iOS platforms follow a very different workflow, which is currently out of scope of the Log Checker. It's not useful on any platform that uses xharness. -->
-    <HelixCorrelationPayload Include="$(XUnitLogCheckerDirectory)" Condition="'$(TargetsBrowser)' != 'true' and '$(TargetsAppleMobile)' != 'true'" />
+    <HelixCorrelationPayload Include="$(XUnitLogCheckerDirectory)" Condition="'$(IsXunitLogCheckerSupported)' == 'true' and '$(TargetsBrowser)' != 'true' and '$(TargetsAppleMobile)' != 'true'" />
     <HelixCorrelationPayload Condition="'$(TestWrapperTargetsWindows)' == 'true'" Include="dotnet-sos">
       <Destination>sos</Destination>
       <Uri>https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/flat2/dotnet-sos/$(DotnetSosVersion)/dotnet-sos.$(DotnetSosVersion).nupkg</Uri>