Skip to content

Commit

Permalink
PlatformNotSupportedException for UNIX domain sockets on iOS/tvOS (#7…
Browse files Browse the repository at this point in the history 
…3374)

* PNSE for domain sockets on iOS/tvOS
* Re-enable some tests which SHOULD now throw PNSE
  • Loading branch information
@directhex
directhex authored Aug 9, 2022
1 parent 6110ab6 commit 9687016
Show file tree
Hide file tree
Showing 26 changed files with 167 additions and 168 deletions.
6 changes: 6 additions & 0 deletions src/libraries/Common/src/System/Net/SocketProtocolSupportPal.Unix.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ internal static partial class SocketProtocolSupportPal
{
private static unsafe bool IsSupported(AddressFamily af)
{
// Check for AF_UNIX on iOS/tvOS. The OS claims to support this, but returns EPERM on bind.
// We should explicitly set the return here to false, to avoid giving a false impression.
if (af == AddressFamily.Unix && (OperatingSystem.IsTvOS() || (OperatingSystem.IsIOS() && !OperatingSystem.IsMacCatalyst())))
{
return false;
}
IntPtr invalid = (IntPtr)(-1);
IntPtr socket = invalid;
try
Expand Down
100 changes: 50 additions & 50 deletions src/libraries/Common/tests/StreamConformanceTests/System/IO/StreamConformanceTests.cs
View file

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions src/libraries/System.IO.FileSystem/tests/Base/FileGetSetAttributes.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void SettingAttributes_Unix_ReadOnly()

[Theory]
[InlineData(FileAttributes.Hidden)]
[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD)]
[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void SettingAttributes_OSXAndFreeBSD(FileAttributes attributes)
{
string path = CreateItem();
Expand Down Expand Up @@ -80,8 +80,7 @@ public void SettingInvalidAttributes_Unix(FileAttributes attributes)

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.FileCreateCaseSensitive))]
[InlineData(FileAttributes.Hidden)]
[PlatformSpecific(TestPlatforms.AnyUnix & ~(TestPlatforms.OSX | TestPlatforms.FreeBSD))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[PlatformSpecific(TestPlatforms.AnyUnix & ~(TestPlatforms.OSX | TestPlatforms.FreeBSD | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst))]
public void SettingInvalidAttributes_UnixExceptOSXAndFreeBSD(FileAttributes attributes)
{
string path = CreateItem();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ public void DriveLetter_Windows()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // drive letters casing
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void DriveLetter_Unix()
{
// On Unix, there's no special casing for drive letters. These may or may not be valid names, depending
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.IO.FileSystem/tests/Directory/Delete.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public void DeletingSymLinkDoesntDeleteTarget()
}

[ConditionalFact(nameof(UsingNewNormalization))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void ExtendedDirectoryWithSubdirectories()
{
DirectoryInfo testDir = Directory.CreateDirectory(IOInputs.ExtendedPrefix + GetTestFilePath());
Expand All @@ -132,7 +132,7 @@ public void ExtendedDirectoryWithSubdirectories()
}

[ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void LongPathExtendedDirectory()
{
DirectoryInfo testDir = Directory.CreateDirectory(IOServices.GetPath(IOInputs.ExtendedPrefix + TestDirectory, characterCount: 500));
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/Exists.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ public void ExtendedPathAlreadyExistsAsFile()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Makes call to native code (libc)
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/GetFileSystemEntries_str_str.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,6 @@ public void WindowsSearchPatternWhitespace()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.FileCreateCaseSensitive))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
public void SearchPatternCaseSensitive()
{
DirectoryInfo testDir = Directory.CreateDirectory(GetTestFilePath());
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/GetLogicalDrives.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public class Directory_GetLogicalDrives
{
[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Valid drive strings on Unix
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
public void GetsValidDriveStrings_Unix()
{
string[] drives = Directory.GetLogicalDrives();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/DirectoryInfo/Exists.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public void FalseForFile()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/File/Exists.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public void PathAlreadyExistsAsDirectory()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void FalseForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytes.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ static async Task WaitConnectionAndWritePipeStreamAsync(NamedPipeServerStream na

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public async Task ReadAllBytes_NonSeekableFileStream_InUnix()
{
string fifoPath = GetTestFilePath();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/File/ReadWriteAllBytesAsync.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ static async Task WaitConnectionAndWritePipeStreamAsync(NamedPipeServerStream na

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public async Task ReadAllBytesAsync_NonSeekableFileStream_InUnix()
{
string fifoPath = GetTestFilePath();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/FileInfo/Exists.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void FalseForDirectory()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void TrueForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.IO.FileSystem/tests/FileStream/DevicesPipesAndSockets.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ public async Task CharacterDevice_WriteAllTextAsync(string devicePath)

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task NamedPipe_ReadWrite()
{
string fifoPath = GetTestFilePath();
Expand All @@ -85,8 +85,8 @@ await Task.WhenAll(

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task NamedPipe_ReadWrite_Async()
{
string fifoPath = GetTestFilePath();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem/tests/Path/Exists_File.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void PathAlreadyExistsAsDirectory()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser)] // Uses P/Invokes
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.tvOS)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/67853", TestPlatforms.iOS | TestPlatforms.tvOS)]
public void TrueForNonRegularFile()
{
string fileName = GetTestFilePath();
Expand Down
9 changes: 6 additions & 3 deletions src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CreateServer.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,16 @@ public static void ReservedPipeName_Throws_ArgumentOutOfRangeException(PipeDirec
AssertExtensions.Throws<ArgumentOutOfRangeException>("pipeName", () => new NamedPipeServerStream(reservedName, direction, 1, PipeTransmissionMode.Byte, PipeOptions.None, 0, 0));}

[Fact]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public static void Create_PipeName()
{
new NamedPipeServerStream(PipeStreamConformanceTests.GetUniquePipeName()).Dispose();
}

[Fact]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public static void Create_PipeName_Direction_MaxInstances()
{
new NamedPipeServerStream(PipeStreamConformanceTests.GetUniquePipeName(), PipeDirection.Out, 1).Dispose();
Expand Down Expand Up @@ -207,7 +209,8 @@ public static void Windows_CreateFromDisposedServerHandle_Throws_ObjectDisposedE

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // accessing SafePipeHandle on Unix fails for a non-connected stream
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public static void Unix_GetHandleOfNewServerStream_Throws_InvalidOperationException()
{
using (var pipe = new NamedPipeServerStream(PipeStreamConformanceTests.GetUniquePipeName(), PipeDirection.Out, 1, PipeTransmissionMode.Byte))
Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.CrossProcess.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace System.IO.Pipes.Tests
public sealed class NamedPipeTest_CrossProcess
{
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
public void InheritHandles_AvailableInChildProcess()
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -46,7 +46,7 @@ void ChildFunc(string handle)
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
public void PingPong_Sync()
{
// Create names for two pipes
Expand All @@ -73,7 +73,7 @@ public void PingPong_Sync()
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
public async Task PingPong_Async()
{
// Create names for two pipes
Expand Down
31 changes: 22 additions & 9 deletions src/libraries/System.IO.Pipes/tests/NamedPipeTests/NamedPipeTest.Specific.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void InvalidConnectTimeout_Throws_ArgumentOutOfRangeException()
}

[Fact]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task ConnectToNonExistentServer_Throws_TimeoutException()
{
using (NamedPipeClientStream client = new NamedPipeClientStream(".", "notthere"))
Expand All @@ -46,6 +47,7 @@ await Assert.ThrowsAsync<TimeoutException>(() =>
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task CancelConnectToNonExistentServer_Throws_OperationCanceledException()
{
using (NamedPipeClientStream client = new NamedPipeClientStream(".", "notthere"))
Expand Down Expand Up @@ -85,7 +87,8 @@ public void ConnectWithConflictingDirections_Throws_UnauthorizedAccessException(
[Theory]
[InlineData(1)]
[InlineData(3)]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task MultipleWaitingClients_ServerServesOneAtATime(int numClients)
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -121,7 +124,8 @@ async Task ConnectClientAndReadAsync()
}

[Fact]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public void MaxNumberOfServerInstances_TooManyServers_Throws()
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -159,7 +163,8 @@ public void MaxNumberOfServerInstances_TooManyServers_Throws()
[Theory]
[InlineData(1)]
[InlineData(4)]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task MultipleServers_ServeMultipleClientsConcurrently(int numServers)
{
string name = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -356,7 +361,8 @@ public async Task Windows_GetImpersonationUserName_Succeed(TokenImpersonationLev

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Uses P/Invoke to verify the user name
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task Unix_GetImpersonationUserName_Succeed()
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -387,7 +393,8 @@ public void Unix_MessagePipeTransmissionMode()
[InlineData(PipeDirection.Out)]
[InlineData(PipeDirection.InOut)]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Unix implementation uses bidirectional sockets
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public static void Unix_BufferSizeRoundtripping(PipeDirection direction)
{
int desiredBufferSize = 0;
Expand Down Expand Up @@ -451,7 +458,8 @@ public static void Windows_BufferSizeRoundtripping()
}

[Fact]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task PipeTransmissionMode_Returns_Byte()
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -507,7 +515,8 @@ public void Windows_SetReadModeTo__PipeTransmissionModeByte()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Unix doesn't currently support message mode
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public void Unix_SetReadModeTo__PipeTransmissionModeByte()
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down Expand Up @@ -548,7 +557,8 @@ public void Unix_SetReadModeTo__PipeTransmissionModeByte()
[Theory]
[InlineData(PipeDirection.Out, PipeDirection.In)]
[InlineData(PipeDirection.In, PipeDirection.Out)]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public void InvalidReadMode_Throws_ArgumentOutOfRangeException(PipeDirection serverDirection, PipeDirection clientDirection)
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand All @@ -566,7 +576,8 @@ public void InvalidReadMode_Throws_ArgumentOutOfRangeException(PipeDirection ser

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[PlatformSpecific(TestPlatforms.AnyUnix)] // Checks MaxLength for PipeName on Unix
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets")]
[SkipOnPlatform(TestPlatforms.LinuxBionic, "SElinux blocks UNIX sockets in our CI environment")]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public void NameTooLong_MaxLengthPerPlatform()
{
// Increase a name's length until it fails
Expand Down Expand Up @@ -611,6 +622,7 @@ public void NameTooLong_MaxLengthPerPlatform()
}

[Fact]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public void ClientConnect_Throws_Timeout_When_Pipe_Not_Found()
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand All @@ -622,6 +634,7 @@ public void ClientConnect_Throws_Timeout_When_Pipe_Not_Found()

[Theory]
[MemberData(nameof(GetCancellationTokens))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "iOS/tvOS blocks binding to UNIX sockets")]
public async Task ClientConnectAsync_Throws_Timeout_When_Pipe_Not_Found(CancellationToken cancellationToken)
{
string pipeName = PipeStreamConformanceTests.GetUniquePipeName();
Expand Down
Loading

0 comments on commit 9687016

Please sign in to comment.