Skip to content

Commit

Permalink
[release/7.0-rc1] Disable failing runtime extra platforms tests (#74264)
Browse files Browse the repository at this point in the history
* Disable tests failing on Android

* Disable test failing on iOS and MacCatalyst

* Disable failing System.Formats.Tar tests on Android

* Fix JIT.Directed aliasing_retbuf test exclusion on Android

* Disable failing TraceSource tests on tvOS

* Remove unnecessary formatting changes

* Fix skipping failing tests on Android

* Skip tests failing on tvOS

* Revert "Disable failing System.Formats.Tar tests on Android"

This reverts commit bfc2958.

* Link to specific issues

Co-authored-by: Simon Rozsival <simon@rozsival.com>
  • Loading branch information
github-actions[bot] and simonrozsival authored Aug 20, 2022
1 parent e897e88 commit a2e9125
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ private static void CreateAndLoadConfigFile(string filename)

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void RuntimeFilterChange()
{
CreateAndLoadConfigFile("testhost_ConfigWithRuntime.config");
Expand Down Expand Up @@ -95,6 +96,7 @@ public void RuntimeFilterChange()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_RemoveSwitch()
{
// Use a SourceSwitch that logs Error.
Expand Down Expand Up @@ -135,6 +137,7 @@ void Log()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_ChangeSwitch()
{
// Use a SourceSwitch that logs Error.
Expand All @@ -160,6 +163,7 @@ public void Refresh_ChangeSwitch()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Refresh_RemoveSource()
{
// Use a SourceSwitch that logs Error.
Expand Down Expand Up @@ -193,6 +197,7 @@ public void Refresh_RemoveSource()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void ConfigWithEvents_RuntimeListener()
{
CreateAndLoadConfigFile("testhost_ConfigWithRuntime.config");
Expand Down Expand Up @@ -259,6 +264,7 @@ private void SubscribeToSwitch_Initializing(object? sender, InitializingSwitchEv

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void AllTypes()
{
CreateAndLoadConfigFile("testhost_AllTypes.config");
Expand Down Expand Up @@ -303,6 +309,7 @@ public void AllTypes()

[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74244", TestPlatforms.tvOS)]
public void Switch_MissingValue_Throws()
{
Exception e = Assert.Throws<ConfigurationErrorsException>(() =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3751,6 +3751,7 @@ public abstract class SocketsHttpHandler_SecurityTest : HttpClientHandlerTestBas
public SocketsHttpHandler_SecurityTest(ITestOutputHelper output) : base(output) { }

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindows7))]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_CustomTrust_Ok()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down Expand Up @@ -3787,6 +3788,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_InvalidName_Throws()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down Expand Up @@ -3817,6 +3819,7 @@ await LoopbackServerFactory.CreateClientAndServerAsync(
}

[Fact]
[SkipOnPlatform(TestPlatforms.Android, "Self-signed certificates are rejected by Android before the .NET validation is reached")]
public async Task SslOptions_CustomPolicy_IgnoresNameMismatch()
{
X509Certificate2Collection caCerts = new X509Certificate2Collection();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ public static void Xml_ListRoot()
// horizon that it's not worth the trouble.
#if !XMLSERIALIZERGENERATORTESTS
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74247", TestPlatforms.tvOS)]
public static void Xml_ReadOnlyCollection()
{
ReadOnlyCollection<string> roc = new ReadOnlyCollection<string>(new string[] { "one", "two" });
Expand All @@ -224,6 +225,7 @@ public static void Xml_ReadOnlyCollection()

[Theory]
[MemberData(nameof(Xml_ImmutableCollections_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/74247", TestPlatforms.tvOS)]
public static void Xml_ImmutableCollections(Type type, object collection, Type createException, Type addException, string expectedXml, string exMsg = null)
{
XmlSerializer serializer;
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/tests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Quic/tests/FunctionalTests/System.Net.Quic.Functional.Tests.csproj" />
<!-- https://github.com/dotnet/runtime/issues/51414 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.OpenSsl/tests/System.Security.Cryptography.OpenSsl.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/74245 -->
<ProjectExclusions Include="$(RepoRoot)/src/tests/FunctionalTests/iOS/Simulator/XmlSerializer_Deserialize/iOS.Simulator.XmlSerializer_Deserialize.Test.csproj" />
<!-- App Crash https://github.com/dotnet/runtime/issues/53624 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Requests/tests/System.Net.Requests.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion src/tests/issues.targets
Original file line number Diff line number Diff line change
Expand Up @@ -3703,7 +3703,7 @@
<ExcludeList Include = "$(XunitTestBinBase)/JIT/CheckProjects/CheckProjects/**">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/aliasing_retbuf/*">
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/aliasing_retbuf/**/*">
<Issue>https://github.com/dotnet/runtime/issues/73539</Issue>
</ExcludeList>
<ExcludeList Include="$(XUnitTestBinBase)/JIT/Directed/callconv/ThisCall/ThisCallTest/*">
Expand Down

0 comments on commit a2e9125

Please sign in to comment.