Skip to content

Commit

Permalink
fix formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
khushal1996 committed Jun 4, 2024
1 parent 7a51e1e commit b1509c4
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
22 changes: 12 additions & 10 deletions src/coreclr/jit/compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -9550,10 +9550,12 @@ class Compiler
}

// Following cases should be taken into consideration when using the below APIs:
// InstructionSet_EVEX implies Avx10v1 -or- Avx512F+CD+DQ+BW+VL and can be used for 128-bit or 256-bit EVEX encoding instructions in these instruction sets
// InstructionSet_Avx10v1_V512 should never be queried directly, it is covered by querying Avx512*
// InstructionSet_Avx512F (and same for BW, CD, DQ) is only queried for 512-bit EVEX encoded instructions
//InstructionSet_Avx10v1 is only queried for cases like 128-bit/256-bit instructions that wouldn't be in F+CD+DQ+BW+VL (such as VBMI) and should appear with a corresponding query around AVX512*_VL (i.e. AVX512_VBMI_VL)
// InstructionSet_EVEX implies Avx10v1 -or- Avx512F+CD+DQ+BW+VL and can be used for 128-bit or 256-bit EVEX encoding
// instructions in these instruction sets InstructionSet_Avx10v1_V512 should never be queried directly, it is
// covered by querying Avx512* InstructionSet_Avx512F (and same for BW, CD, DQ) is only queried for 512-bit EVEX
// encoded instructions
// InstructionSet_Avx10v1 is only queried for cases like 128-bit/256-bit instructions that wouldn't be in
// F+CD+DQ+BW+VL (such as VBMI) and should appear with a corresponding query around AVX512*_VL (i.e. AVX512_VBMI_VL)

#ifdef DEBUG
//------------------------------------------------------------------------
Expand Down Expand Up @@ -9595,12 +9597,12 @@ class Compiler
bool IsAvx10OrIsaSupportedDebugOnly(CORINFO_InstructionSet isa) const
{
#ifdef TARGET_XARCH
//For the below cases, check for evex encoding should be used.
assert(isa != InstructionSet_AVX512F || isa != InstructionSet_AVX512F_VL ||
isa != InstructionSet_AVX512BW || isa != InstructionSet_AVX512BW_VL ||
isa != InstructionSet_AVX512CD || isa != InstructionSet_AVX512CD_VL ||
isa != InstructionSet_AVX512DQ || isa != InstructionSet_AVX512DQ_VL);
// For the below cases, check for evex encoding should be used.
assert(isa != InstructionSet_AVX512F || isa != InstructionSet_AVX512F_VL || isa != InstructionSet_AVX512BW ||
isa != InstructionSet_AVX512BW_VL || isa != InstructionSet_AVX512CD ||
isa != InstructionSet_AVX512CD_VL || isa != InstructionSet_AVX512DQ ||
isa != InstructionSet_AVX512DQ_VL);

return (compIsaSupportedDebugOnly(InstructionSet_AVX10v1) || compIsaSupportedDebugOnly(isa));
#else
return false;
Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/jit/lowerxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9184,8 +9184,7 @@ bool Lowering::IsContainableHWIntrinsicOp(GenTreeHWIntrinsic* parentNode, GenTre
assert(childBaseType == TYP_DOUBLE);
}

if (comp->canUseEvexEncoding() &&
parentNode->OperIsEmbBroadcastCompatible())
if (comp->canUseEvexEncoding() && parentNode->OperIsEmbBroadcastCompatible())
{
GenTree* broadcastOperand = hwintrinsic->Op(1);

Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/jit/morph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ GenTree* Compiler::fgMorphExpandCast(GenTreeCast* tree)
// For pre-SSE41, the all src is converted to TYP_DOUBLE
// and goes through helpers.
&& (tree->gtOverflow() || (dstType == TYP_LONG) ||
!(canUseEvexEncoding() ||
(dstType == TYP_INT && compOpportunisticallyDependsOn(InstructionSet_SSE41))))
!(canUseEvexEncoding() || (dstType == TYP_INT && compOpportunisticallyDependsOn(InstructionSet_SSE41))))
#elif defined(TARGET_ARM)
// Arm: src = float, dst = int64/uint64 or overflow conversion.
&& (tree->gtOverflow() || varTypeIsLong(dstType))
Expand Down

0 comments on commit b1509c4

Please sign in to comment.