Skip to content

Commit

Permalink
Remove the "UNDONE: ..." printing
Browse files Browse the repository at this point in the history
Insert an assert instead about what we expect and handle GCInfo-wise.
  • Loading branch information
SingleAccretion committed Mar 29, 2022
1 parent ed38ad8 commit d3d5326
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions src/coreclr/jit/emitxarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13128,21 +13128,16 @@ BYTE* emitter::emitOutputIV(BYTE* dst, instrDesc* id)
emitRecordRelocation((void*)(dst - sizeof(INT32)), (void*)(size_t)val, IMAGE_REL_BASED_HIGHLOW);
}
}

// Did we push a GC ref value?
if (id->idGCref())
{
#ifdef DEBUG
printf("UNDONE: record GCref push [cns]\n");
#endif
}

break;

default:
assert(!"unexpected instruction");
}

// GC tracking for "push"es is done by "emitStackPush", for all other instructions
// that can reach here we do not expect (and do not handle) GC refs.
assert((ins == INS_push) || !id->idGCref());

return dst;
}

Expand Down

0 comments on commit d3d5326

Please sign in to comment.