Skip to content

Commit

Permalink
Disable additional validation that is run post-build (#37102)
Browse files Browse the repository at this point in the history
* Disable additional validation that is run post-build
Disable more validation stages that are run post-build. The only
thing left to run during each build at this point is SourceLink validation.
Once that is available, the entire validation stage should be able to be skipped
  • Loading branch information
mmitche authored Jun 1, 2020
1 parent e2541c7 commit e3f0247
Showing 1 changed file with 11 additions and 10 deletions.
21 changes: 11 additions & 10 deletions eng/pipelines/official/stages/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,13 @@ stages:
parameters:
validateDependsOn:
- PrepareForPublish
# Symbol validation is not ready yet. https://github.com/dotnet/arcade/issues/2871
# The following checks are run after the build in the validation and release pipelines
# And thus are not enabled here. They can be enabled for dev builds for spot testing if desired
enableSymbolValidation: false
# SourceLink validation doesn't work in dev builds: tries to pull from GitHub. https://github.com/dotnet/arcade/issues/3604
enableSourceLinkValidation: true
# Allow symbol publish to emit expected warnings without failing the build. Include single
# quotes inside the string so that it passes through to MSBuild without script interference.
symbolPublishingAdditionalParameters: "'-warnAsError:$false'"
# Publish to blob storage.
publishInstallersAndChecksums: true
# Enable SDL validation, passing through values from the 'core-setup-sdl-validation' group.
enableSigningValidation: false
enableNugetValidation: false
SDLValidationParameters:
enable: false # TODO: (Consolidation) Decide who owns SDL validation errors and enable. https://github.com/dotnet/runtime/issues/1027
enable: false
artifactNames:
- PackageArtifacts
- BlobArtifacts
Expand All @@ -51,3 +46,9 @@ stages:
-TsaRepositoryName "$(TsaRepositoryName)"
-TsaCodebaseName "$(TsaCodebaseName)"
-TsaPublish $True
# The following checks are not available after the build and continue to be run here
enableSourceLinkValidation: true

# Publish to blob storage.
publishInstallersAndChecksums: true

0 comments on commit e3f0247

Please sign in to comment.