Skip to content

Commit

Permalink
Disable Bidirection tests on WS2022
Browse files Browse the repository at this point in the history
  • Loading branch information
liveans committed Jul 15, 2024
1 parent bd369c6 commit f47ef87
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public static partial class PlatformDetection
public static bool IsWindows8x => IsWindows && GetWindowsVersion() == 6 && (GetWindowsMinorVersion() == 2 || GetWindowsMinorVersion() == 3);
public static bool IsWindows8xOrLater => IsWindowsVersionOrLater(6, 2);
public static bool IsWindows10OrLater => IsWindowsVersionOrLater(10, 0);
public static bool IsWindowsServer2022 => IsWindows && IsNotWindowsNanoServer && GetWindowsVersion() == 10 && GetWindowsMinorVersion() == 0 && GetWindowsBuildVersion() == 20348;

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux_musl arm64 Release)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux_musl arm Release)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build FreeBSD x64 Debug)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux arm Release)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux x64 Debug)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux arm64 Debug)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build Linux_musl x64 Debug)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-staging (Build Build Android x86 Release AllSubsets_Mono)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-staging (Build Build Android arm Release AllSubsets_Mono)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-staging (Build Build Android arm64 Release AllSubsets_Mono)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime-staging (Build Build Android x64 Release AllSubsets_Mono)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Build Browser wasm Release AllSubsets_Mono)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Build Browser wasm Release AllSubsets_Mono_AOT)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Build Browser wasm Release AllSubsets_Mono_EAT)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context

Check failure on line 27 in src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

View check run for this annotation

Azure Pipelines / runtime (Build Libraries Build OSX arm64 Debug)

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs#L27

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs(27,152): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'GetWindowsBuildVersion' does not exist in the current context
public static bool IsWindowsNanoServer => IsWindows && (IsNotWindowsIoTCore && GetWindowsInstallationType().Equals("Nano Server", StringComparison.OrdinalIgnoreCase));
public static bool IsWindowsServerCore => IsWindows && GetWindowsInstallationType().Equals("Server Core", StringComparison.OrdinalIgnoreCase);
public static int WindowsVersion => IsWindows ? (int)GetWindowsVersion() : -1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ public BidirectionStreamingTest(ITestOutputHelper output) : base(output)

// Build number suggested by the WinHttp team.
// It can be reduced if bidirectional streaming is backported.
public static bool OsSupportsWinHttpBidirectionalStreaming => Environment.OSVersion.Version >= new Version(10, 0, 22357, 0);
public static bool OsSupportsWinHttpBidirectionalStreaming => Environment.OSVersion.Version >= new Version(10, 0, 22357, 0) && PlatformDetection.IsWindowsServer2022;

public static bool TestsEnabled => OsSupportsWinHttpBidirectionalStreaming && PlatformDetection.SupportsAlpn;
public static bool TestsEnabled => OsSupportsWinHttpBidirectionalStreaming && PlatformDetection.SupportsAlpn && !PlatformDetection.IsWindowsServer2022;

public static bool TestsBackwardsCompatibilityEnabled => !OsSupportsWinHttpBidirectionalStreaming && PlatformDetection.SupportsAlpn;

Expand Down

0 comments on commit f47ef87

Please sign in to comment.