Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outerloop test builds broken #101628

Closed
AndyAyersMS opened this issue Apr 26, 2024 · 2 comments · Fixed by #101666
Closed

Outerloop test builds broken #101628

AndyAyersMS opened this issue Apr 26, 2024 · 2 comments · Fixed by #101666
Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

Comments

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Apr 26, 2024 •
edited
Loading

Noticed this in some of the jit optional pipelines but it's in outerloop too.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=657460&view=results

/__w/1/s/src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs(71,85): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/coreclr/tools/Common/TypeSystem/Common/Utilities/CustomAttributeTypeNameParser.cs(71,85): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj]
/__w/1/s/src/libraries/Common/src/System/Reflection/TypeNameParser.Helpers.cs(85,31): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/libraries/Common/src/System/Reflection/TypeNameParser.Helpers.cs(85,31): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj]
/__w/1/s/src/libraries/Common/src/System/Reflection/TypeNameParser.Helpers.cs(170,50): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/libraries/Common/src/System/Reflection/TypeNameParser.Helpers.cs(170,50): error CS0436: The type 'TypeName' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs' conflicts with the imported type 'TypeName' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/TypeName.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj]
/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/AssemblyNameInfo.cs(182,23): error CS0436: The type 'AssemblyNameInfo' in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/AssemblyNameInfo.cs' conflicts with the imported type 'AssemblyNameInfo' in 'System.Reflection.Metadata, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. Using the type defined in '/__w/1/s/src/libraries/Common/src/System/Reflection/Metadata/AssemblyNameInfo.cs'. [/__w/1/s/src/tests/ilverify/ILVerificationTests.csproj] [/__w/1/s/src/tests/build.proj]
...etc..

Looks like it all may be ILVerify related.
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 26, 2024
@AndyAyersMS AndyAyersMS added blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs area-Tools-ILVerification Issues related to ilverify tool and IL verification in general and removed area-System.Reflection untriaged New issue has not been triaged by the area owner labels Apr 26, 2024
@AndyAyersMS AndyAyersMS mentioned this issue Apr 26, 2024
Open
@TIHan
Copy link
Contributor

TIHan commented Apr 26, 2024

The failures seem to be occurring after #100094 was merged. cc @adamsitnik

jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be visible from System.Reflection.Metadata only
d5ccb7a 
Fixes dotnet#101628
@jeffhandley
Copy link
Member

I'm interpreting these failures as:

  1. ILVerify and ILCompiler projects were both modified to directly compile the TypeName sources into those projects
  2. But with an indirect dependency onto System.Reflection.Metadata, where the APIs were also available as public APIs, this leads to conflicting types

I see @jkotas has a branch going where he committed changes that:

  1. Make the APIs only public in System.Reflection.Metadata
  2. Instead of compiling the code into the other projects, a direct reference to System.Reflection.Metadata is added to those projects as well
  3. Some refactoring/cleanup is included s well

jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be visible from System.Reflection.Metadata only
8b6e40f 
Fixes dotnet#101628
jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be visible from System.Reflection.Metadata only
1659a7a 
Contributes to dotnet#101541

Fixes dotnet#101628
@jkotas jkotas mentioned this issue Apr 28, 2024
Merged
jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be visible from System.Reflection.Metadata only
cf51ee1 
Contributes to dotnet#101541

Fixes dotnet#101628
jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
25eae15 
…package

Contributes to dotnet#101541

Fixes dotnet#101628

Better unreachable code elimination in CoreLib
jkotas added a commit to jkotas/runtime that referenced this issue Apr 28, 2024
@jkotas
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
5c6a76d 
…package

Contributes to dotnet#101541

Fixes dotnet#101628

Better unreachable code elimination in CoreLib
jkotas added a commit to jkotas/runtime that referenced this issue Apr 29, 2024
@jkotas
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
70524b5 
…package

Contributes to dotnet#101541

Fixes dotnet#101628

Better unreachable code elimination in CoreLib
jkotas added a commit that referenced this issue Apr 29, 2024
@jkotas
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
7745b5e 
…package (#101666)

Contributes to #101541

Fixes #101628
matouskozak pushed a commit to matouskozak/runtime that referenced this issue Apr 30, 2024
@jkotas @matouskozak
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
f6a5bd5 
…package (dotnet#101666)

Contributes to dotnet#101541

Fixes dotnet#101628
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this issue May 9, 2024
@jkotas @michaelgsharp
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
a95770a 
…package (dotnet#101666)

Contributes to dotnet#101541

Fixes dotnet#101628
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this issue May 30, 2024
@jkotas @Ruihan-Yin
Change S.R.M.TypeName to be consumed from System.Reflection.Metadata …
6002cc4 
…package (dotnet#101666)

Contributes to dotnet#101541

Fixes dotnet#101628
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change S.R.M.TypeName to be consumed from System.Reflection.Metadata package jkotas/runtime
3 participants
@jeffhandley @TIHan @AndyAyersMS