Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In official build, use signing and SDL validation team properties based on Runtime team #1027

Closed
dagood opened this issue Dec 18, 2019 · 1 comment
Closed

In official build, use signing and SDL validation team properties based on Runtime team #1027

dagood opened this issue Dec 18, 2019 · 1 comment
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner

Comments

@dagood
Copy link
Member

dagood commented Dec 18, 2019 •
edited
Loading

Right now, the TeamName for signing and some values for SDL validation came from Core-Setup, since it was the last in the set of builds and controls signing. These should be set to something related to the runtime team, not core-setup anymore, and SDL automation should be enabled.

runtime/eng/pipelines/runtime-official.yml

Lines 25 to 27 in 385121f

# TODO: (Consolidation) Switch away from old signing/validation variables from former Core-Setup. https://github.com/dotnet/runtime/issues/1027
- name: TeamName
value: dotnet-core-acquisition

runtime/eng/pipelines/official/stages/publish.yml

Lines 37 to 38 in 385121f

SDLValidationParameters:
enable: false # TODO: (Consolidation) Decide who owns SDL validation errors and enable. https://github.com/dotnet/runtime/issues/1027

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 18, 2019
@dagood dagood changed the title In official build, use a TeamName based on Runtime team In official build, use signing and SDL validation team properties based on Runtime team Dec 18, 2019
@dagood dagood mentioned this issue Feb 13, 2020
Closed
@ViktorHofer
Copy link
Member

SDL validation doesn't run anymore as part of our build. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Jul 1, 2021
@MichalStrehovsky
Ensure we have a DependencyList in TryGetDependenciesForReflectedType (…
3ad5624 
…dotnet#1028)

Psychic debugging tells me this should fix dotnet#1027.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ViktorHofer @dagood @Dotnet-GitSync-Bot