Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed !"Instruction cannot be encoded: IF_DI_2A" #105954

Closed
amanasifkhalid opened this issue Aug 5, 2024 · 1 comment · Fixed by #105958
Closed

JIT: Assertion failed !"Instruction cannot be encoded: IF_DI_2A" #105954

amanasifkhalid opened this issue Aug 5, 2024 · 1 comment · Fixed by #105958
Assignees
@amanasifkhalid
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@amanasifkhalid
Copy link
Member

amanasifkhalid commented Aug 5, 2024 •
edited
Loading

Hit by Antigen on ARM64. Repro is quite large: gist.

On a few SVE-specific paths, we call emitIns_R_R_I directly to emit an add instruction, instead of emitIns_R_R_Imm, which handles immediates too large to fit in the R_R_I variant of add. Should be easy to find and fix these cases.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 5, 2024
@amanasifkhalid amanasifkhalid self-assigned this Aug 5, 2024
@amanasifkhalid amanasifkhalid added arm-sve Work related to arm64 SVE/SVE2 support Priority:2 Work that is important, but not critical for the release and removed untriaged New issue has not been triaged by the area owner labels Aug 5, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid added this to the 9.0.0 milestone Aug 5, 2024
@amanasifkhalid amanasifkhalid mentioned this issue Aug 5, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

ARM64-SVE: Use emitIns_R_R_Imm to handle large immediates correctly amanasifkhalid/runtime
1 participant
@amanasifkhalid