Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: JIT/Regression/JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.cmd #109905

Closed
v-wenyuxu opened this issue Nov 18, 2024 · 2 comments · Fixed by #109835
Closed

Test failure: JIT/Regression/JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.cmd #109905

v-wenyuxu opened this issue Nov 18, 2024 · 2 comments · Fixed by #109835
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged JitStress CLR JIT issues involving JIT internal stress modes
Milestone

Comments

@v-wenyuxu
Copy link

Failed in: runtime-coreclr jitstress-random 20241117.1

Failed tests:

coreclr osx arm64 Checked jitstress_random_2 @ OSX.1200.ARM64.Open
    - JIT/Regression/JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.cmd
coreclr osx arm64 Checked jitstress_random_1 @ OSX.1200.ARM64.Open
    - JIT/Regression/JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.cmd

Error message:

 
Assert failure(PID 16832 [0x000041c0], Thread: 266530 [0x41122]): Assertion failed 'newLayoutCost < currLayoutCost' in 'System.Xml.XmlTextReaderImpl:ParseQName(ubyte,int,byref):int:this' during 'Optimize layout' (IL size 315; hash 0x8ab5d5eb; FullOpts)

    File: /Users/runner/work/1/s/src/coreclr/jit/fgopt.cpp:5380
    Image: /private/tmp/helix/working/A71C091F/p/corerun

ASSERT FAILED
	Expression: (end & ~(~(vm_page_size-1))) == 0
	Location:   line 48 in /Users/runner/work/1/s/src/coreclr/debug/createdump/memoryregion.h
	Function:   MemoryRegion
	Process:    16833
waitpid() returned successfully (wstatus 00000086) WEXITSTATUS 0 WTERMSIG 6
/private/tmp/helix/working/A71C091F/w/A65E0933/e/JIT/Regression/Regression_3/../JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.sh: line 454: 16832 Abort trap: 6           (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

Return code:      1
Raw output file:      /tmp/helix/working/A71C091F/w/A65E0933/uploads/JitBlue/DevDiv_461649/DevDiv_461649/output.txt
Raw output:
BEGIN EXECUTION
/tmp/helix/working/A71C091F/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true DevDiv_461649.dll ''
[createdump] Gathering state for process 16832 
[createdump] Crashing thread 41122 signal 6 (0006)
[createdump] Writing crash report to file /cores/coredump.16832.dmp.crashreport.json
[createdump] Crash report successfully written
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test failed. Trying to see if dump file was created in /cores since 11/17/2024 11:19:18 AM
Processing /cores/coredump.16832.dmp.crashreport.json
Printing stacktrace from '/cores/coredump.16832.dmp.crashreport.json'
Invoking llvm-symbolizer --pretty-print
Errors while running llvm-symbolizer --pretty-print
System.ComponentModel.Win32Exception (2): An error occurred trying to start process 'llvm-symbolizer' with working directory '/private/tmp/helix/working/A71C091F/w/A65E0933/e/JIT/Regression/Regression_3'. No such file or directory
   at System.Diagnostics.Process.ForkAndExecProcess(ProcessStartInfo startInfo, String resolvedFilename, String[] argv, String[] envp, String cwd, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Unix.cs:line 499
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Unix.cs:line 456
   at CoreclrTestLib.CoreclrTestWrapperLib.TryPrintStackTraceFromCrashReport(String crashReportJsonFile, TextWriter outputWriter)
Test Harness Exitcode is : 1
To run the test:
Set up CORE_ROOT and run.
> /private/tmp/helix/working/A71C091F/w/A65E0933/e/JIT/Regression/Regression_3/../JitBlue/DevDiv_461649/DevDiv_461649/DevDiv_461649.sh

Stack trace:

   at Xunit.Assert.True(Nullable`1 condition, String userMessage) in /_/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 141
   at Xunit.Assert.True(Boolean condition, String userMessage) in /_/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 123
   at TestLibrary.OutOfProcessTest.RunOutOfProcessTest(String assemblyPath, String testPathPrefix)
   at Program.<<Main>$>g__TestExecutor331|0_332(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
@v-wenyuxu v-wenyuxu added arch-arm64 blocking-clean-ci-optional Blocking optional rolling runs JitStress CLR JIT issues involving JIT internal stress modes os-mac-os-x macOS aka OSX labels Nov 18, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Nov 18, 2024
@amanasifkhalid
Copy link
Member

Duplicate of #109831

@amanasifkhalid amanasifkhalid marked this as a duplicate of #109831 Nov 18, 2024
@amanasifkhalid amanasifkhalid self-assigned this Nov 18, 2024
@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed arch-arm64 os-mac-os-x macOS aka OSX untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 18, 2024
@amanasifkhalid amanasifkhalid added this to the 10.0.0 milestone Nov 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 18, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
Follow-up to dotnet#109741. Fixes dotnet#109831. Fixes dotnet#109905. Fixes dotnet#109903.

Tolerate some floating-point imprecision when comparing the cost of a new layout produced by 3-opt to the previous layout's cost. The JitStress failures I looked all stressed JitOptRepeat, which can produce absurdly large loop block weights by rerunning optSetBlockWeights. Manually inspecting the layout decisions made for these methods shows 3-opt making reasonable transformations, but the assertion newLayoutCost < currLayoutCost fails due to imprecision from summing large block weights. Having a backup check that the layout costs are within some epsilon seems like a reasonable fix.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants