Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrossGen can't support GCPOLL_INLINE #13591

Closed
AaronRobinsonMSFT opened this issue Oct 15, 2019 · 1 comment · Fixed by #39376
Closed

CrossGen can't support GCPOLL_INLINE #13591

AaronRobinsonMSFT opened this issue Oct 15, 2019 · 1 comment · Fixed by #39376
Labels
area-CrossGen/NGEN-coreclr
Milestone
5.0.0

Comments

@AaronRobinsonMSFT
Copy link
Member

During the suppress GC transition work, it was discovered that CrossGen can't support indirect memory addresses that are required for GCPOLL_INLINE. This work was discussed with @davidwrighton and attempted, but was blocked by issues referenced in https://github.com/dotnet/coreclr/issues/27186.

/cc @davidwrighton @MichalStrehovsky @sergiy-k
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@erozenfeld erozenfeld mentioned this issue Jul 2, 2020
Closed
@erozenfeld
Copy link
Member

@jkotas #13582 is done so should be unblocked.

@erozenfeld erozenfeld mentioned this issue Jul 14, 2020
Open
jkotas added a commit to jkotas/runtime that referenced this issue Jul 15, 2020
@jkotas
Add support for GCPOLL_INLINE for crossgen
285f4ca 
Fixes dotnet#13591
@jkotas jkotas mentioned this issue Jul 15, 2020
Merged
jkotas added a commit that referenced this issue Jul 16, 2020
@jkotas
Add support for GCPOLL_INLINE for crossgen (#39376)
aff5cf7 
Fixes #13591
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-CrossGen/NGEN-coreclr
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add support for GCPOLL_INLINE for crossgen jkotas/runtime
3 participants
@msftgits @erozenfeld @AaronRobinsonMSFT