Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Runtime.Serialization.Xml test failure on OSX #1417

Closed
jiayi11 opened this issue Nov 7, 2018 · 2 comments · Fixed by #98007
Closed

System.Runtime.Serialization.Xml test failure on OSX #1417

jiayi11 opened this issue Nov 7, 2018 · 2 comments · Fixed by #98007
Labels
area-Serialization disabled-test The test is disabled in source code against the issue
Milestone
Future

Comments

@jiayi11
Copy link
Member

jiayi11 commented Nov 7, 2018

A DataContract Serializer serializing deeply linked list test was added in this pr. However, the test fails on OSX with StackOverFlow exception. Failed build status can be found here. We already disabled the test on OSX, but still need to investigate the reason of the failure.
@jiayi11 jiayi11 pinned this issue Dec 15, 2018
@jiayi11 jiayi11 unpinned this issue Dec 15, 2018
@StephenBonikowsky StephenBonikowsky transferred this issue from dotnet/corefx Jan 7, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Serialization untriaged New issue has not been triaged by the area owner labels Jan 7, 2020
@StephenBonikowsky StephenBonikowsky added this to the Future milestone Jan 7, 2020
@StephenBonikowsky StephenBonikowsky added disabled-test The test is disabled in source code against the issue and removed untriaged New issue has not been triaged by the area owner labels Jan 7, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@StephenBonikowsky StephenBonikowsky removed the untriaged New issue has not been triaged by the area owner label Feb 28, 2020
@StephenBonikowsky
Copy link
Member

@imcarolwang Could you create a PR removing the skip attribute on this test to see if the test still fails. There should be a "Do Not Merge" or similar label you can put on the PR to make sure it doesn't get merged.

@StephenBonikowsky StephenBonikowsky removed this from the Future milestone Mar 5, 2020
@imcarolwang imcarolwang mentioned this issue Apr 30, 2020
Closed
@imcarolwang
Copy link
Contributor

Case still fail with Stack Overflow error on OSX in the PR build checks, but it doesn't repro when I run the standalone test app on our own osx10.12 locally.

@HongGit HongGit added this to the Future milestone Jul 1, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Dec 9, 2021
@MichalStrehovsky
Update issues.targets (dotnet#1417)
6898c59
@lewing lewing mentioned this issue May 4, 2022
Closed
@hamarb123 hamarb123 mentioned this issue Feb 6, 2024
Merged
6 tasks
hamarb123 added a commit to hamarb123/runtime that referenced this issue Feb 6, 2024
@hamarb123
Re-enable some tests, and respect IlcDefaultStackSize on Windows
8ca1c96 
- Re-enable disabled tests tracked by dotnet#1417 and dotnet#2084
- Make stack size configurable on NAOT via `IlcDefaultStackSize` on Windows
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 7, 2024
jkotas pushed a commit that referenced this issue Feb 12, 2024
@hamarb123
Change stack size on all Apple and desktop platforms to at least 1.5MB (
e5df956 
#98007)

* Change stack size to 1.5MB on all desktop platforms & re-enable some tests

* Re-enable some tests, and respect `IlcDefaultStackSize` on Windows

- Re-enable disabled tests tracked by #1417 and #2084
- Make stack size configurable on NAOT via `IlcDefaultStackSize` on Windows
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Serialization disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Change stack size on all desktop platforms to at least 1.5MB hamarb123/runtime
6 participants
@maryamariyan @StephenBonikowsky @HongGit @jiayi11 @imcarolwang @Dotnet-GitSync-Bot