-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DecompressionMethods.Brotli? #24986
Comments
I knew I wasn't wrong to wish for a |
@stephentoub, should this be Also, can we also have |
No, it's a [Flags] enum. It needs to be a unique bit. |
@karelz can we put this on the short list for 2.2 as part of finishing the brotli e2e? Related aspnet/BasicMiddleware#217 |
Sure why not. We didn't review issues for 2.2 yet. So anything in Future is potential 2.2 at this point. |
I am very interested in an |
@jnm2, please open a separate issue. |
Certainly! Sorry for missing the approval tag on this one. |
System.Net.DecompressionMethods is an enum that is used by HttpClient handlers to determine whether/what to automatically decode in a response, e.g. if DecompressionMethods.Deflate is set and the response is encoded with deflate, it'll automatically decode the response as part of handing it back.
The enum today is just:
but we now also have BrotliStream, which we could use to support a DecompressionMethods.Brotli and a "br" encoding:
From an implementation perspective, this would mean either System.Net.Http.dll taking a dependency on System.IO.Compression.Brotli.dll, or if we wanted to avoid the dependency, building all of the source into System.Net.Http.dll (there is currently a native dependency, with the native portion compiled into clrcompression.dll on Windows and System.IO.Compression.Native.so/dylib on Unix).
The text was updated successfully, but these errors were encountered: