Add DecompressionMethods.Brotli?

[stephentoub]

System.Net.DecompressionMethods is an enum that is used by HttpClient handlers to determine whether/what to automatically decode in a response, e.g. if DecompressionMethods.Deflate is set and the response is encoded with deflate, it'll automatically decode the response as part of handing it back.

The enum today is just:

namespace System.Net
{
    [Flags]
    public enum DecompressionMethods
    {
        None = 0,
        GZip = 1,
        Deflate = 2
    }
}

but we now also have BrotliStream, which we could use to support a DecompressionMethods.Brotli and a "br" encoding:

namespace System.Net
{
    [Flags]
    public enum DecompressionMethods
    {
        ...
        Brotli = 4
    }
}

From an implementation perspective, this would mean either System.Net.Http.dll taking a dependency on System.IO.Compression.Brotli.dll, or if we wanted to avoid the dependency, building all of the source into System.Net.Http.dll (there is currently a native dependency, with the native portion compiled into clrcompression.dll on Windows and System.IO.Compression.Native.so/dylib on Unix).

[jnm2]

I knew I wasn't wrong to wish for a DecompressionMethods.All member. Since that sums up exactly what I care about.

[ghost]

    Brotli = 4

@stephentoub, should this be 3 instead?

Also, can we also have All = ~None option as @jnm2 stated?

[stephentoub]

should this be 3 instead?

No, it's a [Flags] enum. It needs to be a unique bit.

[joshfree]

@karelz can we put this on the short list for 2.2 as part of finishing the brotli e2e?

Related aspnet/BasicMiddleware#217

[karelz]

Sure why not. We didn't review issues for 2.2 yet. So anything in Future is potential 2.2 at this point.

[jnm2]

I am very interested in an All member. Would you please review that possibility?

[stephentoub]

@jnm2, please open a separate issue.

[jnm2]

Certainly! Sorry for missing the approval tag on this one.