Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json.Serialization.Tests.ConstructorTests_StringTValue.OtherPropertiesAreSet fails with nullref #33928

Closed
trylek opened this issue Mar 22, 2020 · 2 comments · Fixed by #34248
Assignees
Labels
area-System.Text.Json bug disabled-test The test is disabled in source code against the issue
Milestone

Comments

@trylek
Copy link
Member

trylek commented Mar 22, 2020

Build job: Libraries Test Run release mono Linux x64 Release

Example pipeline: https://dev.azure.com/dnceng/public/_build/results?buildId=568935&view=logs&j=3b5945b0-87a7-52cf-843a-406c21a8e27e&t=7eb56c92-15af-5ace-3e2c-14c3e65847f5

Failure log:

  Starting:    System.Text.Json.Tests (parallel test collections = on, max threads = 2)
    System.Text.Json.Serialization.Tests.ConstructorTests_StringTValue.OtherPropertiesAreSet [FAIL]
      System.NullReferenceException : Object reference not set to an instance of an object
      Stack Trace:
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.Small.cs(25,0): at System.Text.Json.Serialization.Converters.SmallObjectWithParameterizedConstructorConverter`5[[System.Text.Json.Serialization.Tests.Point_2D_With_ExtData_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51],[System.Int32, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Int32, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e],[System.Object, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].CreateObject(ReadStackFrame& frame)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs(35,0): at System.Text.Json.Serialization.Converters.ObjectWithParameterizedConstructorConverter`1[[System.Text.Json.Serialization.Tests.Point_2D_With_ExtData_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, Point_2D_With_ExtData_Class& value)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs(159,0): at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.Point_2D_With_ExtData_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, Point_2D_With_ExtData_Class& value)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoOfTTypeToConvert.cs(164,0): at System.Text.Json.JsonPropertyInfo`1[[System.Text.Json.Serialization.Tests.Point_2D_With_ExtData_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectDefaultConverter.cs(379,0): at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1[[System.Text.Json.Serialization.Tests.Person_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].ReadPropertyValue(Object obj, ReadStack& state, Utf8JsonReader& reader, JsonPropertyInfo jsonPropertyInfo, Boolean useExtensionProperty)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectWithParameterizedConstructorConverter.cs(67,0): at System.Text.Json.Serialization.Converters.ObjectWithParameterizedConstructorConverter`1[[System.Text.Json.Serialization.Tests.Person_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, Person_Class& value)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.cs(159,0): at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.Person_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, Person_Class& value)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterOfT.ReadCore.cs(61,0): at System.Text.Json.Serialization.JsonConverter`1[[System.Text.Json.Serialization.Tests.Person_Class, System.Text.Json.Tests, Version=5.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51]].ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Helpers.cs(26,0): at System.Text.Json.JsonSerializer.ReadCore[Person_Class](JsonConverter jsonConverter, Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.Helpers.cs(18,0): at System.Text.Json.JsonSerializer.ReadCore[Person_Class](Utf8JsonReader& reader, Type returnType, JsonSerializerOptions options)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.String.cs(116,0): at System.Text.Json.JsonSerializer.Deserialize[Person_Class](String json, Type returnType, JsonSerializerOptions options)
        /_/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.String.cs(47,0): at System.Text.Json.JsonSerializer.Deserialize[Person_Class](String json, JsonSerializerOptions options)
        /_/src/libraries/System.Text.Json/tests/Serialization/DeserializationWrapper.cs(26,0): at System.Text.Json.Serialization.Tests.DeserializationWrapper.StringTValueSerializerWrapper.Deserialize[Person_Class](String json, JsonSerializerOptions options)
        /_/src/libraries/System.Text.Json/tests/Serialization/ConstructorTests.ParameterMatching.cs(307,0): at System.Text.Json.Serialization.Tests.ConstructorTests.OtherPropertiesAreSet()
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(339,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Text.Json.Tests
=== TEST EXECUTION SUMMARY ===
   System.Text.Json.Tests  Total: 11731, Errors: 0, Failed: 1, Skipped: 0, Time: 37.764s
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 22, 2020
@jkotas
Copy link
Member

jkotas commented Mar 22, 2020

Hit again in #33933

@jkotas jkotas added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Mar 22, 2020
@layomia layomia self-assigned this Mar 22, 2020
@layomia layomia added this to the 5.0 milestone Mar 22, 2020
@ericstj
Copy link
Member

ericstj commented Mar 23, 2020

Here's the data from the last 100 builds:

Build Kind Console Log
568452 PR #33852 console.log
568335 PR #33674 console.log
568266 Rolling console.log
567761 PR #33892 console.log
568935 Rolling console.log
568318 PR #33911 console.log
568678 Rolling console.log
569159 PR #33933 console.log
568167 Rolling console.log

@stephentoub stephentoub added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels Mar 24, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Mar 24, 2020
@layomia layomia added the bug label Mar 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json bug disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants