[release/5.0-preview3] Cache parameterized ctor delegates in class info rather than converter #34353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#34248) * Cache parameterized ctor delegates in class info rather than converter * Address review feedback - move delegate assignment to start of deserialization * Address review feedback - nullability
layomia
added
bug
Servicing-consider
ericstj
approved these changes
Apr 3, 2020
ericstj
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports #34248 to preview 3.
Fixes #33928 in preview 3.
A
JsonSerializerfeature that enables the deserialization of POCOs using parameterized ctors was recently checked in - #33444.CI caught an issue where
JsonSerializerleaks a null ref in some cases where deserialization of objects using parameterized ctors is occurring on multiple threads: #33928. This PR fixes the issue.Customer Impact
Prevents a null ref in multi-threaded deserialization scenarios. Users are likely to hit this when deserializing objects using parameterized ctors on mutliple threads. This proactively fixes the issue.
Regression?
This feature is shipping for the first time in this preview.
Risk
Tests have been added for this scenario.