Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate the use of properties defined in targetframework.props #34525

Closed
Anipik opened this issue Apr 3, 2020 · 3 comments · Fixed by #35799
Closed

Eliminate the use of properties defined in targetframework.props #34525

Anipik opened this issue Apr 3, 2020 · 3 comments · Fixed by #35799
Assignees
@Anipik
Labels
area-Infrastructure-libraries
Milestone
5.0.0

Comments

@Anipik
Copy link
Contributor

Anipik commented Apr 3, 2020

We moved all the properties depending on targetFramework to targetframework.props.
We should now work on removing these properties from all .props file and csprojs as tfm derived properties should only be in .targets file.

cc @ericstj @ViktorHofer
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Apr 3, 2020
@ghost
Copy link

ghost commented Apr 3, 2020

Tagging @safern, @ViktorHofer as an area owner

@Anipik Anipik mentioned this issue Apr 4, 2020
Merged
@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Apr 17, 2020
@ericstj ericstj added this to the 5.0 milestone Apr 17, 2020
@ericstj
Copy link
Member

ericstj commented Apr 17, 2020

Please focus on doing this now. We're seeing too many related issues due to this problem.

@ericstj ericstj mentioned this issue Apr 17, 2020
Closed
@Anipik
Copy link
Contributor Author

Anipik commented Apr 17, 2020

Sure i can move this up the priority list

@ViktorHofer ViktorHofer mentioned this issue Apr 20, 2020
Merged
@Anipik Anipik mentioned this issue May 4, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Anipik Anipik

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

using the new sdk hook
3 participants
@ericstj @Anipik @Dotnet-GitSync-Bot