Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running libraries tests in VS using launchSettings.json fails #35031

Closed
layomia opened this issue Apr 15, 2020 · 6 comments · Fixed by #35322
Closed

Running libraries tests in VS using launchSettings.json fails #35031

layomia opened this issue Apr 15, 2020 · 6 comments · Fixed by #35322

Comments

@layomia
Copy link
Contributor

layomia commented Apr 15, 2020

When using .NET Core xUnit Console profile I get the following error:

The application to execute does not exist: 'xunit.console.dll'

D:\repos\dotnet_runtime_2\artifacts\bin\testhost\netcoreapp5.0-Windows_NT-Debug-x64\dotnet.exe (process 45676) exited with code -2147450751.
To automatically close the console when debugging stops, enable Tools->Options->Debugging->Automatically close the console when debugging stops.

Chatted with @safern and it seems to be an issue with the RunWorkingDirectory having the wrong value in Design Time Build. If I manually change the workingDirectory in launchSettings.json from "$(RunWorkingDirectory)" to the hardcoded path to the test run working directory, I can run tests fine.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Apr 15, 2020
@ghost
Copy link

ghost commented Apr 15, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member

safern commented Apr 15, 2020

cc: @Anipik

@ViktorHofer
Copy link
Member

RunWorkingDirectory is derived from OutputPath. @ericstj @Anipik I strongly believe we should fix the actual issue which is getting rid of TargetFramework reads from msbuild files which are imported before the project is evaluated, instead of working around the various fallouts. Does that sound reasonable?

@ericstj
Copy link
Member

ericstj commented Apr 16, 2020

@ericstj @Anipik I strongly believe we should fix the actual issue which is getting rid of TargetFramework reads from msbuild files which are imported before the project is evaluated, instead of working around the various fallouts.

Agreed. @Anipik has been driving towards this. @Anipik can we go ahead and do so completely?

This would mean looking at all Directory.Build.props and all the props from our Arcade packages and project files ensuring they don't read TargetFramework in PropertyGroup.

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label Apr 17, 2020
@ericstj ericstj added this to the 5.0 milestone Apr 17, 2020
@ericstj
Copy link
Member

ericstj commented Apr 17, 2020

Effectively a dup of #34525 but leaving this open to track the scenario.

@Anipik
Copy link
Contributor

Anipik commented Apr 17, 2020

@Anipik can we go ahead and do so completely?

Sure i can move this up the priority list

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants