-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running libraries tests in VS using launchSettings.json fails #35031
Comments
Tagging subscribers to this area: @safern, @ViktorHofer |
cc: @Anipik |
RunWorkingDirectory is derived from OutputPath. @ericstj @Anipik I strongly believe we should fix the actual issue which is getting rid of TargetFramework reads from msbuild files which are imported before the project is evaluated, instead of working around the various fallouts. Does that sound reasonable? |
Agreed. @Anipik has been driving towards this. @Anipik can we go ahead and do so completely? This would mean looking at all Directory.Build.props and all the props from our Arcade packages and project files ensuring they don't read TargetFramework in PropertyGroup. |
Effectively a dup of #34525 but leaving this open to track the scenario. |
Sure i can move this up the priority list |
When using .NET Core xUnit Console profile I get the following error:
Chatted with @safern and it seems to be an issue with the
RunWorkingDirectory
having the wrong value in Design Time Build. If I manually change the workingDirectory in launchSettings.json from "$(RunWorkingDirectory)" to the hardcoded path to the test run working directory, I can run tests fine.The text was updated successfully, but these errors were encountered: