Microsoft.Extensions.DependencyModel dependencies for .NET Framework

[jkotas]

#34296 bumped the versions of its dependencies as side-effect. It breaks ingestions of Microsoft.Extensions.DependencyModel into SDK: dotnet/sdk#11246 (comment)

[ghost]

Tagging subscribers to this area: @eerhardt
Notify danmosemsft if you want to be subscribed.

[eerhardt]

Doing an initial investigation, it appears the reason System.Runtime.CompilerServices.Unsafe, 5.0.0.0 is being brought in on .NET Framework is because Microsoft.Extensions.DependencyModel is now referencing System.Text.Json on net461 (which references System.Runtime.CompilerServices.Unsafe, 5.0.0.0). Previously, DependencyModel was using Newtonsoft.Json, which doesn't bring in a newer System.Runtime.CompilerServices.Unsafe.

I believe what Microsoft.Extensions.DependencyModel is doing now is the correct thing to do going foward. So to resolve this issue, I think we either need to bump Microsoft.NET.HostModel to a newer System.Text.Json version, or we need to add a binding redirect.

[eerhardt]

@swaroop-sridhar - is there a reason that Microsoft.NET.HostModel is using an older version of System.Text.Json?

runtime/src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj

Line 19 in 1cfccd2

<PackageReference Include="System.Text.Json" Version="4.7.0" />

Why isn't this compiling against the System.Text.Json that is in src\libraries?

[elinor-fung]

cc @jkoritzinsky - version of System.Text.Json was explicitly set in #2115

[jkoritzinsky]

The version was explicitly set because the version of System.Runtime.CompilerServices.Unsafe in the 5.0 package was broken at the time and that was blocking dotnet/runtime uptake to dotnet/sdk.

[eerhardt]

the version of System.Runtime.CompilerServices.Unsafe in the 5.0 package was broken at the time

But that was fixed with #1918, right? Do we know of a reason why Microsoft.NET.HostModel shouldn't reference the 5.0.0 version of System.Text.Json now?

[jkoritzinsky]

I didn't want to risk breaking anything by moving things, so I never went to go back to fix it.

[eerhardt]

This was verified with dotnet/sdk#11329. New versions of Microsoft.Extensions.DependencyModel are now consumed in dotnet/sdk.

[ericstj]

@eerhardt did you intend to keep this consuming System.Text.Json via package? It looks like that's still the case (and the version has remained at Preview4) and additionally it is using an API which is now marked obsolete: IgnoreNullValues

runtime/src/installer/managed/Microsoft.NET.HostModel/ComHost/ClsidMap.cs

Line 68 in 6072e4d

writer.Write(JsonSerializer.Serialize(clsidMap, new JsonSerializerOptions { IgnoreNullValues = true }));

c2291eb /cc @layomia

[eerhardt]

@eerhardt did you intend to keep this consuming System.Text.Json via package?

My intention with this change was to unblock the ingestion of the new DependencyModel library.

The uber issue tracking HostModel's dependency on System.Text.Json is #1823.