Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore task failing on our solutions #37358

Closed
Anipik opened this issue Jun 3, 2020 · 2 comments · Fixed by #38294
Closed

Restore task failing on our solutions #37358

Anipik opened this issue Jun 3, 2020 · 2 comments · Fixed by #38294
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner

Comments

@Anipik
Copy link
Contributor

Anipik commented Jun 3, 2020

Expected behavior

C:\Users\anagniho\source\repos\ConsoleApp10>dotnet build ConsoleApp10.sln
Microsoft (R) Build Engine version 16.7.0-preview-20270-03+bee129d1b for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  Restored C:\Users\anagniho\source\repos\ConsoleApp10\ConsoleApp10.csproj (in 345 ms).
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
  ConsoleApp10 -> C:\Users\anagniho\source\repos\ConsoleApp10\bin\Debug\netcoreapp3.1\ConsoleApp10.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:03.34

Actual Behavior

C:\git\runtime\src\libraries\System.Diagnostics.TraceSource>dotnet build
Microsoft (R) Build Engine version 16.7.0-preview-20270-03+bee129d1b for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
C:\Program Files\dotnet\sdk\5.0.100-preview.6.20301.7\NuGet.targets(128,5): error : Object reference not set to an instance of an object. [C:\git\runtime\src\libraries\System.Diagnostics.TraceSource\System.Diagnostics.TraceSource.sln]

Build FAILED.

cc @ericstj @ViktorHofer @safern

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 23, 2020

Spoke with @jeffkl. Static graph restore currently doesn't work on slns. We probably need to bring back this piece of code in the TargetFramework SDK: dotnet/arcade@4a290d3#diff-e3462a51d4395b12c22c7012edc37a3fL43-L59

EDIT: it works, the solution simply didn't honor the static graph restore feature switch. See linked PR.

ViktorHofer added a commit that referenced this issue Jun 23, 2020
ViktorHofer added a commit that referenced this issue Jun 23, 2020
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this issue Jul 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants