Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linker analysis and add baselines for warnings #38033

Closed
eerhardt opened this issue Jun 17, 2020 · 4 comments
Closed

Enable linker analysis and add baselines for warnings #38033

eerhardt opened this issue Jun 17, 2020 · 4 comments
Assignees
Labels
area-Meta linkable-framework Issues associated with delivering a linker friendly framework
Milestone

Comments

@eerhardt
Copy link
Member

dotnet/linker#1030 will change the ILLinker that it will start adding warnings by default when it detects unsafe use of reflection. This will cause our libraries build to start emitting a lot of warnings (in the hundreds).

To keep our build clean, we should add a "baseline" of linker warnings to the repo, which will suppress the warnings. In the future, as we annotate the usages of reflection to make them linker-safe, we can remove the suppressions.

To suppress individual warnings, we can create a LinkerSuppressions.cs file in each project that will contain UnconditionalSuppressMessage attributes. @mateoatr is working on a mechanism that can generate these suppress message attributes that we can use to bootstrap the baselines.

cc @vitek-karas

@joperezr
Copy link
Member

@eerhardt @layomia isn't this done already?

@layomia
Copy link
Contributor

layomia commented Aug 25, 2020

@joperezr not yet - I need to update #40691 following the new linker warning codes brought in with #40865.

@layomia
Copy link
Contributor

layomia commented Sep 3, 2020

Moving to 6.0 as this isn't needed for 5.0.

@eerhardt
Copy link
Member Author

Resolved by #40691. Closing.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
5 participants