Update linker warning numbers #40865
Conversation
In response to dotnet/linker#1385. This replaces the global suppressions for IL2006 with the warnings that it was split into.
sbomer
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
sbomer
requested review from
eerhardt,
layomia,
vitek-karas and
MichalStrehovsky
|
Yup, I checked the modified |
| @@ -26,7 +26,7 @@ public static partial class Marshal | |||
| [MethodImpl(MethodImplOptions.InternalCall)] | |||
| internal static extern int SizeOfHelper(Type t, bool throwIfNotMarshalable); | |||
|
|
|||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2006:UnrecognizedReflectionPattern", | |||
| [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern", | |||
There was a problem hiding this comment.
probably not a huge deal, but do we have a better string than UnrecognizedReflectionPattern now? It sort of made sense when IL2006 was used, but now we are using 30 differnet codes, all with "UnrecognizedReflectionPattern"
There was a problem hiding this comment.
@mateoatr does this string have any particular meaning? It looks to me like you could put anything here and the linker would treat it the same. I agree it'd be nice to come up with more specific names for these.
There was a problem hiding this comment.
My understanding is that linker doesn't actually look at that string, so it should be possible to use really anything. @mateoatr would know for sure.
There was a problem hiding this comment.
Feel free to not address this in this PR to unblock you for 5.0. But it would be nice to get something like this early in 6.0.
It is totally a convenience for the readers - but it is a useful convenience IMO, so I don't need to look up the error code from https://github.com/mono/linker/blob/master/docs/error-codes.md each time.
There was a problem hiding this comment.
Filed dotnet/linker#1432 for this
There was a problem hiding this comment.
Yeah, any string can be used here and it shouldn't affect the linker.
ghost
locked as resolved and limited conversation to collaborators
In response to dotnet/linker#1385.
This updates the linker and replaces the global suppressions for IL2006 with the warnings that it was split into.