-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression in SimpleConstructors test inside System.Xml.Linq.TreeManipulation.Tests #44489
Comments
Tagging subscribers to this area: @buyaa-n, @krwq, @jeffhandley Issue meta data
|
This was introduced here: runtime/src/libraries/System.Private.Xml.Linq/tests/TreeManipulation/SimpleObjectsCreation.cs Lines 926 to 927 in 6072e4d
|
failed again in job: runtime-libraries-coreclr outerloop 20201117.1 failed test: XLinqTests.TreeManipulationTests.SimpleConstructors net6.0-Linux-Release-arm64-CoreCLR_release-(Alpine.312.Arm64.Open)ubuntu.1804.armarch.open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.12-helix-arm64v8-20200602002604-25f8a3e Error message
|
There is actually a bit regression as serialized output differs a bit (prints extra |
BTW the test seems pretty fast and stable. Is there reason to keep it as Outerloop? |
@wfurt IIRC I initially measured the tests before marking them outerloop and I put some threshold of some number of milliseconds after which we started being too slow overall for XML, initially the guidelines for inner loop were much stricter I believe so we can reconsider that now. Let's split this investigation from the fix though |
I can reproduce it locally - the caveat is that this is outer loop test so I guess it got missed by CI.
I was suspecting #44414 but I can reproduce it even when syncing prior to that.
I started to fail 11/10 .e.g. today.
Binary search points to #44300
cc: @krwq and @stephentoub who touch the area recently.
There is not much aside from:
The text was updated successfully, but these errors were encountered: