Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hundreds of thousands of tests failed with Assertion failed 'firstILBlock->hasProfileWeight()' in 'System.Runtime.CompilerServices.CastHelpers:StelemRef(System.Array,int,System.Object)' during 'Compute edge weights (1, false)' (IL size 86) #47839

Closed
VincentBu opened this issue Feb 4, 2021 · 2 comments · Fixed by #47876
Closed

Hundreds of thousands of tests failed with Assertion failed 'firstILBlock->hasProfileWeight()' in 'System.Runtime.CompilerServices.CastHelpers:StelemRef(System.Array,int,System.Object)' during 'Compute edge weights (1, false)' (IL size 86) #47839

VincentBu opened this issue Feb 4, 2021 · 2 comments · Fixed by #47876
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Milestone
6.0.0

Comments

@VincentBu
Copy link
Contributor

Run : runtime-coreclr jitstress 20210202.1

Hundreds of thousands of tests failed here.

Error message:

Assert failure(PID 1296 [0x00000510], Thread: 1296 [0x0510]): Assertion failed 'firstILBlock->hasProfileWeight()' in 'System.Runtime.CompilerServices.CastHelpers:StelemRef(System.Array,int,System.Object)' during 'Compute edge weights (1, false)' (IL size 86)

 File: /__w/1/s/src/coreclr/jit/fgprofile.cpp Line: 1362
 Image: /root/helix/work/correlation/corerun

/root/helix/work/workitem/JIT/CodeGenBringUpTests/LocallocCnstB1_PSP_ro/LocallocCnstB1_PSP_ro.sh: line 388: 1296 Aborted (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

Return code: 1
Raw output file: /root/helix/work/workitem/JIT/CodeGenBringUpTests/Reports/JIT.CodeGenBringUpTests/LocallocCnstB1_PSP_ro/LocallocCnstB1_PSP_ro.output.txt
Raw output:
BEGIN EXECUTION
/root/helix/work/correlation/corerun LocallocCnstB1_PSP_ro.dll ''
Gathering state for process 1296 corerun
Writing minidump with heap to file /home/helixbot/dotnetbuild/dumps/coredump.1296.dmp
Written 45867008 bytes (11198 pages) to core file
Dump successfully written
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:
> set CORE_ROOT=/root/helix/work/correlation
> /root/helix/work/workitem/JIT/CodeGenBringUpTests/LocallocCnstB1_PSP_ro/LocallocCnstB1_PSP_ro.sh
Expected: True
Actual: False
@VincentBu VincentBu added the JitStress CLR JIT issues involving JIT internal stress modes label Feb 4, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Feb 4, 2021
@AndyAyersMS
Copy link
Member

Guessing this is my fault.

Jit stress, I though we were friends....

@AndyAyersMS AndyAyersMS self-assigned this Feb 4, 2021
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Feb 4, 2021
@AndyAyersMS AndyAyersMS added this to the 6.0.0 milestone Feb 4, 2021
@AndyAyersMS
Copy link
Member

Need to generalize when we run the new "incorporate profile data" phase. Should have a PR up shortly.

AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Feb 4, 2021
@AndyAyersMS
JIT: fix interaction of PGO and jitstress
7034073 
We always need to run the profile data phase so that jit stress can inject
random profile counts if it so chooses.

Also, clean up a few dumping nits -- don't dump the profile query status until
we get around to trying to incorporate counts; summarize schema records before
asserting that we must have block counts, etc.

Closes dotnet#47839
@AndyAyersMS AndyAyersMS mentioned this issue Feb 4, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 4, 2021
AndyAyersMS added a commit that referenced this issue Feb 5, 2021
@AndyAyersMS
JIT: fix interaction of PGO and jitstress (#47876)
5b41e82 
We always need to run the profile data phase so that jit stress can inject
random profile counts if it so chooses.

Also, clean up a few dumping nits -- don't dump the profile query status until
we get around to trying to incorporate counts; summarize schema records before
asserting that we must have block counts, etc.

Closes #47839
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Projects
.NET Core CodeGen
Archived in project
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix interaction of PGO and jitstress AndyAyersMS/runtime
2 participants
@AndyAyersMS @VincentBu