-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adhere to the package support policy by building and packaging supported frameworks only #53282
Comments
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsContinuation of #47530 The runtime repository currently produces 102 packages from libraries of which 25 of those contain assets which will be unsupported when we release .NET 6 in November 2021. The list of unsupported assets includes netstandard1.x assets as those apply to unsupported application frameworks only as in any case where a netstandard1.x asset is present, a netstandard2.0 (and in most cases a net461 asset) exists as well which allows to run on .NET Framework 4.6.1 or .NET Core 3.1 and above. The reasons for trimming out unsupported assets are:
Based on these disadvantages we will remove the remaining unsupported assets from packages in dotnet/runtime. List of packages grouped by TargetFrameworkIdentifierNETStandard,Version=1.x -> .NETStandard,Version=2.0
NETCoreApp,Version=2.x|3.0 -> .NETCoreApp,Version=3.1
NETFramework,Version=4.5|4.5.1|4.6 -> .NETFramework.Version=4.6.1
cc @danmoseley @ericstj @terrajobst @Anipik
|
These ten projects still built for netstandard1.x. This PR trims out these assets from both the build which also results in them not being packaged anymore as there is no harvesting mechanism in the repository anymore. Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to dotnet#53282
* Remove NS1.x assets from build and packaging These ten projects still built for netstandard1.x. This PR trims out these assets from both the build which also results in them not being packaged anymore as there is no harvesting mechanism in the repository anymore. Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to #53282
Only a very few number of projects still built for net45-net46. This PR trims out these assets from the build which of course results in them not being packaged (as there is no harvesting mechanism in the repository present anymore). Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to dotnet#53282
Aren't net452, net460, and net461 supported through April 2022? |
#53319) Only a very few number of projects still built for net45-net46. This PR trims out these assets from the build which of course results in them not being packaged (as there is no harvesting mechanism in the repository present anymore). Suppressing the package warnings for the intentionally dropped assets and cleaning up conditions in the project file as well. For more details please see the reasoning in the linked issue. Contributes to #53282
Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations in projects to netcoreapp3.1 and cleaning up conditions so that future tfm upgrades require less project file changes. Adding NETStandardError markers to prevent available netstandard2.0 assets being picked instead, same as already done for System.Speech and others. For more details please see the reasoning in the linked issue. Contributes to dotnet#53282
You are right. For .NET Framework we decided to upgrade to net461 as that's the earliest version that support .NET Standard 2.0 which is the baseline for our packages. The table above shows that only 13 packages targeted an earlier version of .NET Framework as the majority already moved to net461 or later. Thanks for linking to the document. That indicates that we want to upgrade our .NET Framework assets again when we branch off for NET7 which will likely release next year in November. |
I was confused about the phrase "assets which will be unsupported when we release .NET 6 in November 2021". I interpreted that as "assets that target frameworks which will be unsupported when we release .NET 6 in November 2021". But I guess you meant "assets which will be unsupported by .NET 6 when we release in November 2021", which makes more sense. |
Upgrading the netcoreapp2.x and netcoreapp3.0 build configurations in projects to netcoreapp3.1 and cleaning up conditions so that future tfm upgrades require less project file changes. Adding NETStandardError markers to prevent available netstandard2.0 assets being picked instead, same as already done for System.Speech and others. For more details please see the reasoning in the linked issue. Contributes to #53282
Closing as work is completed. |
Continuation of #47530
The runtime repository currently produces 102 packages from libraries of which 25 of those contain assets which will be unsupported when we release .NET 6 in November 2021. The list of unsupported assets includes netstandard1.x assets as those apply to unsupported application frameworks only as in any case where a netstandard1.x asset is present, a netstandard2.0 (and in most cases a net461 asset) exists as well which allows to run on .NET Framework 4.6.1 or .NET Core 3.1 and above.
The reasons for trimming out unsupported assets are:
Based on these disadvantages we will remove the remaining unsupported assets from packages in dotnet/runtime.
List of packages grouped by TargetFrameworkIdentifier
NETStandard,Version=1.x -> .NETStandard,Version=2.0
PR: #53283
NETCoreApp,Version=2.x|3.0 -> .NETCoreApp,Version=3.1
PR: #53358
NETFramework,Version=4.5|4.5.1|4.6 -> .NETFramework.Version=4.6.1
PR: #53319
cc @danmoseley @ericstj @terrajobst @Anipik
The text was updated successfully, but these errors were encountered: