-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] NRE in System.Runtime.InteropServices.JavaScript.Runtime.SetupJSContinuation
, for System.Xml.Linq.xNodeBuilder.Tests
#53614
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsPR: #53557
The error went away on a rebuild though. Opening this issue, in case this is seen again. cc @kg
|
Does this seem like a regression? Or just an existing bug we weren't noticing? |
My first check around continuations would be GC. |
Yeah, it's quite likely this is a GC issue, but also the arguments to this function are marked as non-nullable when they're nullable, so it's possible a null is making its way in from the JS side. The code doesn't handle that. |
I spent a while trying to reproduce this but can't get it to fail, it must rely on something about the CI hardware. I'll have to just audit and rework the code. |
Happened again on
|
🤕 |
Happened here too #54186 |
PR: #53557
Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1166367&view=logs&jobId=108d2c4a-8a62-5a58-8dad-8e1042acc93c&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4
Test log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-53557-merge-f508128941754676b8/System.Xml.Linq.xNodeBuilder.Tests/console.14abc845.log?sv=2019-07-07&se=2021-06-21T23%3A56%3A15Z&sr=c&sp=rl&sig=LF0p6D8awZ1HOuwt79yvT8cmtp4%2FQhoKfPQ22FLswvI%3D
The error went away on a rebuild though. Opening this issue, in case this is seen again.
cc @kg
The text was updated successfully, but these errors were encountered: