-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Redesign of managed objects marshaling and lifecycle #56538
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
6fd322e
to
a644cb3
Compare
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
- GCHandle instead of int sequence - generalization of delegate invocation to any parameters
af61c61
to
f6947e0
Compare
....Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs
Show resolved
Hide resolved
....InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/DelegateTests.cs
Outdated
Show resolved
Hide resolved
...e.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/AnyRef.cs
Outdated
Show resolved
Hide resolved
I think anything else that needs to be done to this code can be done in later PRs, this looks more than good enough |
The test failures are all unrelated to this pr but the runtime (Libraries Test Run release coreclr Linux x64 Debug) is odd
|
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
Redesign of all managed object marshaling and lifecycle
Runtime._weakDelegateTable
andRuntime._rawToJS
JSObject.WeakRawObject
andJSObject.RawObject
jsHandle
orgcHandle
as appropriatejsHandle
mathFixes #55735 delegate GC
Fixes #55679 delegate GC
Fixes #53614 task GC