Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline dependency issue: Artifact CoreCLRProduct bits missing. #53842

Closed
hoyosjs opened this issue Jun 8, 2021 · 7 comments · Fixed by #54094
Closed

Pipeline dependency issue: Artifact CoreCLRProduct bits missing. #53842

hoyosjs opened this issue Jun 8, 2021 · 7 comments · Fixed by #54094
Labels
area-Infrastructure

Comments

@hoyosjs
Copy link
Member

hoyosjs commented Jun 8, 2021 •
edited by runfoapp bot
Loading

We have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087

This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary.

cc: @dotnet/runtime-infrastructure

Runfo Tracking Issue: Pipeline dependency issue: Artifact CoreCLRProduct bits missing.

Definition Build Kind Job Name
runtime 1178491 PR 53920 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1178491 PR 53920 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1177036 Rolling Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1177036 Rolling Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1176617 PR 53439 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176617 PR 53439 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1176566 PR 52866 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1176566 PR 52866 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176412 PR 53698 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1176412 PR 53698 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176339 PR 53866 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176091 Rolling Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176091 Rolling Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1176063 PR 53669 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1176063 PR 53669 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1175897 Rolling Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1175897 Rolling Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1175285 PR 53836 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1175285 PR 53836 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1175261 PR 53763 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1175261 PR 53763 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1174593 PR 53606 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1174593 PR 53606 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1174517 Rolling Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1174291 PR 53806 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1174264 PR 52791 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1174264 PR 52791 Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime 1174155 Rolling Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1174093 PR 53656 Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime 1174093 PR 53656 Mono minijit Pri0 Runtime Tests Run OSX x64 release

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
2 17 17
@ghost
Copy link

ghost commented Jun 8, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

We have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087

This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary.

cc: @dotnet/runtime-infrastructure

Author: hoyosjs
Assignees: -
Labels:

area-Infrastructure
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 8, 2021
@hoyosjs
Copy link
Member Author

hoyosjs commented Jun 8, 2021

Is CoreCLR's product build needed to build the coreroot on mono's builds?

@SingleAccretion
Copy link
Contributor

SingleAccretion commented Jun 8, 2021 •
edited
Loading

Is CoreCLR's product build needed to build the coreroot on mono's builds?

I believe so, see also #53421.

@hoyosjs
Copy link
Member Author

hoyosjs commented Jun 8, 2021

So yes, based on the last comment this is bad.

@hoyosjs hoyosjs removed the untriaged New issue has not been triaged by the area owner label Jun 9, 2021
@akoeplinger
Copy link
Member

If someone knows how to add the dependency in the .yml please feel free to do it :)

@directhex
Copy link
Contributor

directhex commented Jun 10, 2021 via email

@safern
Copy link
Member

safern commented Jun 10, 2021

This is a known issue that came out during the surge and that @naricc was working on. #43952

It seems like he has not gotten cycles to fix it.

the short term fix should be make sure we are getting the right dependency always for mono against coreclr here:

runtime/eng/pipelines/common/templates/runtimes/run-test-job.yml

Line 66 in 43b1f2c

- ${{ if or( eq(parameters.runtimeVariant, 'minijit'), eq(parameters.runtimeVariant, 'monointerpreter')) }}:

hoyosjs added a commit to hoyosjs/runtime that referenced this issue Jun 12, 2021
@hoyosjs
Add dependency on coreclr in monojit/monointerpreter jobs explicitly …
232aabe 
…to solve pipeline issue dotnet#53842
@hoyosjs hoyosjs mentioned this issue Jun 12, 2021
Merged
@hoyosjs hoyosjs linked a pull request Jun 12, 2021 that will close this issue
Infrastructure: correct dependencies and clean helix agent from stray corerun procs #54094
Merged
hoyosjs added a commit that referenced this issue Jun 13, 2021
@hoyosjs @kunalspathak
Infrastructure: correct dependencies and clean helix agent from stray…
86cebb3 
… corerun procs (#54094)

* Add dependency on coreclr in monojit/monointerpreter jobs explicitly to solve pipeline issue #53842
* Use Helix Pre/Post hooks to kill linkering corerun instances to work around ARM64 agent issues

Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infrastructure: correct dependencies and clean helix agent from stray corerun procs hoyosjs/runtime
5 participants
@directhex @akoeplinger @hoyosjs @safern @SingleAccretion