Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SgenCommandTest prohibits improvements to generated code #54470

Closed
stephentoub opened this issue Jun 21, 2021 · 0 comments · Fixed by #56877
Closed

SgenCommandTest prohibits improvements to generated code #54470

stephentoub opened this issue Jun 21, 2021 · 0 comments · Fixed by #56877
Assignees
@HongGit @StephenMolloy
Labels
area-Serialization test-enhancement Improvements of test source code

Comments

@stephentoub
Copy link
Member

The Microsoft.XmlSerializer.Generator.Tests.SgenTests.SgenCommandTest test runs sgen from a previous SDK against the live tool and requires that the generated code have exactly the same length. That prohibits making any meaningful improvements to the generated code, as doing so almost invariably will end up changing the length of the generated code.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 21, 2021
@HongGit HongGit removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2021
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 11, 2021
Closed
@StephenMolloy StephenMolloy added the test-enhancement Improvements of test source code label Jul 27, 2021
@StephenMolloy StephenMolloy self-assigned this Jul 27, 2021
@StephenMolloy StephenMolloy mentioned this issue Jul 29, 2021
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 29, 2021
@StephenMolloy StephenMolloy mentioned this issue Aug 4, 2021
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HongGit HongGit

@StephenMolloy StephenMolloy

Labels
area-Serialization test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
3 participants
@stephentoub @HongGit @StephenMolloy