Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlSerializerGenerator tests get in the way when change is expected #55469

Closed
StephenMolloy opened this issue Jul 11, 2021 · 3 comments
Closed
Assignees
Labels
area-Serialization disabled-test The test is disabled in source code against the issue
Milestone

Comments

@StephenMolloy
Copy link
Member

This is a test issue. The tests for XmlSerializer are broken when the output from
the tool is expected to change with a PR. That's because the test project launches
the pre-installed older version of dotnet.exe to produce a serializer code file, and
then calls the newly built generator binary to create another serializer code file,
and then compares the two. In theory, the idea is that nothing should change
between the two, and if something does change, that means the PR broke
something.

Which is not the case when testing a PR that is expected to change the serializer
code being generated. (Like adding support for a new primitive type for example.
Like we're doing in #55101.)

I'm going to disable the XmlSerializerGenerator tests in that PR while it gets
merged, and we can re-enable them when the pre-installed dotnet.exe catches up.

@StephenMolloy StephenMolloy added the disabled-test The test is disabled in source code against the issue label Jul 11, 2021
@StephenMolloy StephenMolloy added this to the 6.0.0 milestone Jul 11, 2021
@StephenMolloy StephenMolloy self-assigned this Jul 11, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Serialization untriaged New issue has not been triaged by the area owner labels Jul 11, 2021
@StephenMolloy StephenMolloy removed the untriaged New issue has not been triaged by the area owner label Jul 11, 2021
@MichalStrehovsky
Copy link
Member

Is this the same as #54470?

@StephenMolloy
Copy link
Member Author

Yup. I must have missed that one.

But I think this one can stay assigned to me and be used for short-term tracking to remind me to re-enable the SGen tests, while the other bug can remain active (and pushed to the future if necessary since it's a test issue) so the team can decide on a better approach and fix this set of tests in the future.

@StephenMolloy
Copy link
Member Author

Addressed in #56877.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Serialization disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

2 participants